Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable HTTPRouteReferenceGrant test #2005

Closed
arkodg opened this issue Oct 18, 2023 · 0 comments · Fixed by #2007
Closed

Enable HTTPRouteReferenceGrant test #2005

arkodg opened this issue Oct 18, 2023 · 0 comments · Fixed by #2007
Assignees
@arkodg
Labels
area/conformance Gateway API Conformance Related Issues help wanted Extra attention is needed
Milestone
0.6.0-rc1

Comments

@arkodg
Copy link
Contributor

arkodg commented Oct 18, 2023

Description:
test details in https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/tests/httproute-reference-grant.go
Once fixed, please enable in https://github.com/envoyproxy/gateway/blob/main/test/conformance/conformance_test.go
&
https://github.com/envoyproxy/gateway/blob/main/test/conformance/experimental_conformance_test.go

Skipped in #1987
@arkodg arkodg added area/conformance Gateway API Conformance Related Issues help wanted Extra attention is needed labels Oct 18, 2023
@arkodg arkodg added this to the 0.6.0-rc1 milestone Oct 18, 2023
arkodg added a commit to arkodg/gateway that referenced this issue Oct 19, 2023
@arkodg
register for v1beta1 gateway api
4833cf5 
* `ReferenceGrant` is still on v1beta1

Fixes: envoyproxy#2005

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg mentioned this issue Oct 19, 2023
Merged
@arkodg arkodg self-assigned this Oct 19, 2023
Xunzhuo added a commit that referenced this issue Oct 19, 2023
@arkodg @Xunzhuo
register for v1beta1 gateway api (#2007)
98213e4 
* register for v1beta1 gateway api

* `ReferenceGrant` is still on v1beta1

Fixes: #2005

Signed-off-by: Arko Dasgupta <[email protected]>

* watch v1b1

Signed-off-by: Arko Dasgupta <[email protected]>

* v1b1 everywhere for ref grant

Signed-off-by: Arko Dasgupta <[email protected]>

* add scheme in conformance test

Signed-off-by: Arko Dasgupta <[email protected]>

* fix typo

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
Co-authored-by: Xunzhuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkodg arkodg

Labels
area/conformance Gateway API Conformance Related Issues help wanted Extra attention is needed
Projects
None yet
Milestone
0.6.0-rc1
Development

Successfully merging a pull request may close this issue.

register for v1beta1 gateway api arkodg/gateway
1 participant
@arkodg