Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The new helm template in generate-manifests doesn't create namespace #1307

Closed
tommie opened this issue Apr 14, 2023 · 0 comments · Fixed by #1332
Closed

The new helm template in generate-manifests doesn't create namespace #1307

tommie opened this issue Apr 14, 2023 · 0 comments · Fixed by #1332
Assignees
@arkodg
Labels
area/installation kind/bug Something isn't working
Milestone
0.4.0

Comments

@tommie
Copy link
Contributor

tommie commented Apr 14, 2023

Description:

When running make generate-manifests in main, the generated bin/install.yaml cannot be installed, because namespace/envoy-gateway-system is not created. namespace/gateway-system from upstream CRDs is created. It doesn't look like this was intentional.

Repro steps:

git clone ...
make generate-manifests
grep -A4 'kind: Namespace' bin/install.yaml

# Compare to
curl -L https://github.com/envoyproxy/gateway/releases/download/v0.3.0/install.yaml | grep -A4 'kind: Namespace'

Related
@tommie tommie added the kind/bug Something isn't working label Apr 14, 2023
@tommie tommie mentioned this issue Apr 14, 2023
Closed
@arkodg arkodg added area/installation help wanted Extra attention is needed labels Apr 14, 2023
@arkodg arkodg mentioned this issue Apr 18, 2023
Closed
@arkodg arkodg added this to the 0.4.0 milestone Apr 18, 2023
arkodg added a commit to arkodg/gateway that referenced this issue Apr 19, 2023
@arkodg
Add the namespace resource within helm templates
f1fc385 
This is unfortunate workaround due the difference in
UX between `helm template` and `helm install`
The project recommends `helm install` as a way to install
EG which supports a `--create-namespace` flag to create a namespace
However we also generate a static YAML using `helm template` as part of
the release artficat so a user can install the YAML directly using
`kubectl` instead of `helm` . The issue here is `helm template` does
not support `--create-namespace`, so instead this commit adds a knob
called `createNamespace` to the Helm chart which is `false` by default,
but turned on during `make generate-manifests`

Fixes: envoyproxy#1307

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg mentioned this issue Apr 19, 2023
Merged
@arkodg arkodg self-assigned this Apr 19, 2023
@arkodg arkodg removed the help wanted Extra attention is needed label Apr 19, 2023
Xunzhuo pushed a commit that referenced this issue Apr 20, 2023
@arkodg
fix: add the namespace resource within helm templates (#1332)
9d6d699 
Add the namespace resource within helm templates

This is unfortunate workaround due the difference in
UX between `helm template` and `helm install`
The project recommends `helm install` as a way to install
EG which supports a `--create-namespace` flag to create a namespace
However we also generate a static YAML using `helm template` as part of
the release artficat so a user can install the YAML directly using
`kubectl` instead of `helm` . The issue here is `helm template` does
not support `--create-namespace`, so instead this commit adds a knob
called `createNamespace` to the Helm chart which is `false` by default,
but turned on during `make generate-manifests`

Fixes: #1307

Signed-off-by: Arko Dasgupta <[email protected]>
Alice-Lilith pushed a commit that referenced this issue Apr 24, 2023
@arkodg
fix: add the namespace resource within helm templates (#1332)
1fafcc3 
Add the namespace resource within helm templates

This is unfortunate workaround due the difference in
UX between `helm template` and `helm install`
The project recommends `helm install` as a way to install
EG which supports a `--create-namespace` flag to create a namespace
However we also generate a static YAML using `helm template` as part of
the release artficat so a user can install the YAML directly using
`kubectl` instead of `helm` . The issue here is `helm template` does
not support `--create-namespace`, so instead this commit adds a knob
called `createNamespace` to the Helm chart which is `false` by default,
but turned on during `make generate-manifests`

Fixes: #1307

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit 9d6d699)
Signed-off-by: AliceProxy <[email protected]>
Alice-Lilith pushed a commit that referenced this issue Apr 24, 2023
@arkodg
Release - 0.4.0: Cherry Pick Fixes (#1350)
c92514f 
* Extension: fix pointer error (#1323)

(cherry picked from commit 2bf9607)
Signed-off-by: AliceProxy <[email protected]>

* fix: add the namespace resource within helm templates (#1332)

Add the namespace resource within helm templates

This is unfortunate workaround due the difference in
UX between `helm template` and `helm install`
The project recommends `helm install` as a way to install
EG which supports a `--create-namespace` flag to create a namespace
However we also generate a static YAML using `helm template` as part of
the release artficat so a user can install the YAML directly using
`kubectl` instead of `helm` . The issue here is `helm template` does
not support `--create-namespace`, so instead this commit adds a knob
called `createNamespace` to the Helm chart which is `false` by default,
but turned on during `make generate-manifests`

Fixes: #1307

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit 9d6d699)
Signed-off-by: AliceProxy <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: AliceProxy <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkodg arkodg

Labels
area/installation kind/bug Something isn't working
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

fix: add the namespace resource within helm templates arkodg/gateway
2 participants
@tommie @arkodg