Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Envoy Gateway in different Deployment modes #1117

Closed
3 of 6 tasks
arkodg opened this issue Mar 9, 2023 · 2 comments
Closed
3 of 6 tasks

Configure Envoy Gateway in different Deployment modes #1117

arkodg opened this issue Mar 9, 2023 · 2 comments
Labels
area/api API-related issues area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. area/provider help wanted Extra attention is needed kind/enhancement New feature or request
Milestone
Backlog

Comments

@arkodg
Copy link
Contributor

arkodg commented Mar 9, 2023 •
edited
Loading

Description:
Today by default, Envoy Gateway watches for resources (Gateways, HTTPRoutes) in all namespaces, and deploys managed resources (Envoy Deployment, Service) in a single namespace (where EG is running e.g. envoy-gateway-system)
It would be great if the project supported other modes such as

  • watch for resources in a single namespace and/or
  • deploy in multiple namespaces (where Gateway is created)
  • API
  • Implement
  • Docs

This intent could be defined in the EnvoyGateway config

[optional Relevant Links:]
Relates to #1067
@arkodg arkodg added kind/enhancement New feature or request help wanted Extra attention is needed area/api API-related issues area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. area/provider labels Mar 9, 2023
@zirain
Copy link
Member

zirain commented Mar 9, 2023

+1 for option (2)

@arkodg arkodg mentioned this issue Mar 14, 2023
Open
@arkodg
Copy link
Contributor Author

arkodg commented Mar 31, 2023

thinking out loud, potential API could look like

deploymentMode:
  watch:
    namespaces: .........
  deploy:
    envoy:
      namespaceType: GatewayNamespace
  • By default (when this field is unset), EG watches all resources in all namespaces, and depoys infra in the namespace where EG is running (ControllerNamespace)
  • watch.namespaces can be used to set the specific namespaces to watch resources (Gateway, xRoute, Service etc)
  • deploy.envoy.namespaceType can be used to specify to EG to deploy proxy infra to deploy envoy deployments in the namespace where the Gateway is created in. This option will need a helm knob too, to configure added permissions to be able to create deployments and services in other namespaces

@arkodg arkodg mentioned this issue Apr 12, 2023
Closed
arkodg added a commit to arkodg/gateway that referenced this issue May 10, 2023
@arkodg
Add API for Deployment Mode
a3bddd3 
Relates to envoyproxy#1117

```
apiVersion: config.gateway.envoyproxy.io/v1alpha1
kind: EnvoyGateway
gateway:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
provider:
  type: Kubernetes
  kubernetes:
    mode:
      watch:
        namespaces:
	- "ns-1"
	- "ns-2"
```

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg mentioned this issue May 10, 2023
Merged
zirain pushed a commit that referenced this issue May 17, 2023
@arkodg
feat: add API for Deployment Mode (#1413)
efe575a 
* Add API for Deployment Mode

Relates to #1117

```
apiVersion: config.gateway.envoyproxy.io/v1alpha1
kind: EnvoyGateway
gateway:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
provider:
  type: Kubernetes
  kubernetes:
    mode:
      watch:
        namespaces:
	- "ns-1"
	- "ns-2"
```

Signed-off-by: Arko Dasgupta <[email protected]>

* rm top level mode

Signed-off-by: Arko Dasgupta <[email protected]>

* fix

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
tanujd11 pushed a commit to tanujd11/gateway that referenced this issue May 20, 2023
@arkodg @tanujd11
feat: add API for Deployment Mode (envoyproxy#1413)
22c63a9 
* Add API for Deployment Mode

Relates to envoyproxy#1117

```
apiVersion: config.gateway.envoyproxy.io/v1alpha1
kind: EnvoyGateway
gateway:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
provider:
  type: Kubernetes
  kubernetes:
    mode:
      watch:
        namespaces:
	- "ns-1"
	- "ns-2"
```

Signed-off-by: Arko Dasgupta <[email protected]>

* rm top level mode

Signed-off-by: Arko Dasgupta <[email protected]>

* fix

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit to arkodg/gateway that referenced this issue Jun 30, 2023
@arkodg
Implement Watch Namespaces
108f219 
Relates to envoyproxy#1117

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg mentioned this issue Jun 30, 2023
Merged
arkodg added a commit that referenced this issue Jul 4, 2023
@arkodg
Implement Watch Namespaces (#1610)
3892d90 
* Implement Watch Namespaces

Relates to #1117

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg mentioned this issue Jul 4, 2023
Closed
@Xunzhuo Xunzhuo added this to the v1.0.0-rc1 milestone Dec 7, 2023
@arkodg arkodg removed the road-to-ga label Feb 8, 2024
@arkodg arkodg modified the milestones: v1.0.0-rc1, Backlog Feb 8, 2024
@arkodg arkodg mentioned this issue Feb 16, 2024
Open
@arkodg arkodg closed this as completed Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api API-related issues area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. area/provider help wanted Extra attention is needed kind/enhancement New feature or request
Projects
No open projects
Envoy Gateway: The Road to GA
Status: Done
Milestone
Backlog
Development

No branches or pull requests
3 participants
@zirain @arkodg @Xunzhuo