Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement File Provider #1001

Closed
danehans opened this issue Feb 8, 2023 · 7 comments
Closed

Implement File Provider #1001

danehans opened this issue Feb 8, 2023 · 7 comments
Labels
kind/enhancement New feature or request stale
Milestone

Comments

@danehans
Copy link
Contributor

danehans commented Feb 8, 2023

Currently, the EnvoyProxy API defines a File provider. This provider should be implemented or removed.

@danehans danehans added the kind/enhancement New feature or request label Feb 8, 2023
@danehans danehans added this to the Backlog milestone Feb 8, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Mar 10, 2023
@lizj3624
Copy link

+1

@github-actions github-actions bot removed the stale label Mar 11, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Apr 10, 2023
@arkodg arkodg removed the stale label Apr 20, 2023
@arkodg
Copy link
Contributor

arkodg commented Apr 20, 2023

Jotting down some thoughts here
Today, EG provides a top level field called Provider

Provider *EnvoyGatewayProvider `json:"provider,omitempty"`
and supports Kubernetes as a provider.
The provider noun could be broken down into two parts

  • Config Provider - which provides input config (from a file, kubernetes)
  • Infra Provider - which provides an infrastructure to deploy the output resources (envoyproxy fleet) in

So by default we support

provider:
  type: Kubernetes
  kubernetes:
   ....

We can add support for custom Provider type

provider:
  type: Custom
  custom:
    config:
      type: File
      file:
      ....
    infrastructure:
      type: Docker
      docker:
      .... 

@arkodg
Copy link
Contributor

arkodg commented Apr 20, 2023

cc @cpakulski

arkodg added a commit to arkodg/gateway that referenced this issue May 1, 2023
zirain pushed a commit that referenced this issue May 4, 2023
* design: Run Envoy Gateway locally on host

Relates to #1001
& #1035

Signed-off-by: Arko Dasgupta <[email protected]>

* lint

Signed-off-by: Arko Dasgupta <[email protected]>

* lint

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label May 20, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Dec 7, 2023

Track on #1393

@Xunzhuo Xunzhuo closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

4 participants