Skip to content

Commit

Permalink
fix egctl release artifacts
Browse files Browse the repository at this point in the history
* the release artifact for `egctl` was being pulled from
the `latest` release instead of a binary associated with
the release tag

Signed-off-by: Arko Dasgupta <[email protected]>
  • Loading branch information
arkodg committed Oct 30, 2024
1 parent b0c6f8c commit 9a83b42
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 14 deletions.
16 changes: 12 additions & 4 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ jobs:
name: benchmark_report
path: release-artifacts

- name: Build egctl multiarch binaries
run: |
make build-multiarch BINS="egctl"
tar -zcvf egctl_${{ env.release_tag }}_linux_amd64.tar.gz bin/linux/amd64/
tar -zcvf egctl_${{ env.release_tag }}_linux_arm64.tar.gz bin/linux/arm64/
tar -zcvf egctl_${{ env.release_tag }}_darwin_amd64.tar.gz bin/darwin/amd64/
tar -zcvf egctl_${{ env.release_tag }}_darwin_arm64.tar.gz bin/darwin/arm64/
- name: Upload Release Manifests
uses: softprops/action-gh-release@c062e08bd532815e2082a85e87e3ef29c3e6d191 # v0.1.15
with:
Expand All @@ -88,7 +96,7 @@ jobs:
release-artifacts/quickstart.yaml
release-artifacts/release-notes.yaml
release-artifacts/benchmark_report.zip
release-artifacts/egctl_${{ env.release_tag }}_linux_amd64.tar.gz
release-artifacts/egctl_${{ env.release_tag }}_linux_arm64.tar.gz
release-artifacts/egctl_${{ env.release_tag }}_darwin_amd64.tar.gz
release-artifacts/egctl_${{ env.release_tag }}_darwin_arm64.tar.gz
egctl_${{ env.release_tag }}_linux_amd64.tar.gz
egctl_${{ env.release_tag }}_linux_arm64.tar.gz
egctl_${{ env.release_tag }}_darwin_amd64.tar.gz
egctl_${{ env.release_tag }}_darwin_arm64.tar.gz
11 changes: 1 addition & 10 deletions tools/make/kube.mk
Original file line number Diff line number Diff line change
Expand Up @@ -249,16 +249,7 @@ generate-manifests: helm-generate.gateway-helm ## Generate Kubernetes release ma
@$(call log, "Added: $(OUTPUT_DIR)/quickstart.yaml")

.PHONY: generate-artifacts
generate-artifacts: generate-manifests generate-egctl-releases ## Generate release artifacts.
generate-artifacts: generate-manifests ## Generate release artifacts.
@$(LOG_TARGET)
cp -r $(ROOT_DIR)/release-notes/$(TAG).yaml $(OUTPUT_DIR)/release-notes.yaml
@$(call log, "Added: $(OUTPUT_DIR)/release-notes.yaml")

.PHONY: generate-egctl-releases
generate-egctl-releases: ## Generate egctl releases
@$(LOG_TARGET)
mkdir -p $(OUTPUT_DIR)/
curl -sSL https://github.com/envoyproxy/gateway/releases/download/latest/egctl_latest_darwin_amd64.tar.gz -o $(OUTPUT_DIR)/egctl_$(TAG)_darwin_amd64.tar.gz
curl -sSL https://github.com/envoyproxy/gateway/releases/download/latest/egctl_latest_darwin_arm64.tar.gz -o $(OUTPUT_DIR)/egctl_$(TAG)_darwin_arm64.tar.gz
curl -sSL https://github.com/envoyproxy/gateway/releases/download/latest/egctl_latest_linux_amd64.tar.gz -o $(OUTPUT_DIR)/egctl_$(TAG)_linux_amd64.tar.gz
curl -sSL https://github.com/envoyproxy/gateway/releases/download/latest/egctl_latest_linux_arm64.tar.gz -o $(OUTPUT_DIR)/egctl_$(TAG)_linux_arm64.tar.gz

0 comments on commit 9a83b42

Please sign in to comment.