Skip to content

Commit

Permalink
minor wording
Browse files Browse the repository at this point in the history
Signed-off-by: Huabing Zhao <[email protected]>
  • Loading branch information
zhaohuabing committed Jun 21, 2024
1 parent 2e96e1c commit 7f8f8e0
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 10 deletions.
4 changes: 2 additions & 2 deletions api/v1alpha1/wasm_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,9 @@ type HTTPWasmCodeSource struct {
type ImageWasmCodeSource struct {
// URL is the URL of the OCI image.
// URL can be in the format of `registry/image:tag` or `registry/image@sha256:digest`.
// The image format must follow the Wasm Artifact Image Specification or the Compat Spec.
// The image format must follow the Wasm Artifact Image Specification or the Compat Specification.
// - Wasm Artifact Image Specification: https://github.com/solo-io/wasm/blob/master/spec/spec.md
// - Compat spec image: https://github.com/solo-io/wasm/blob/master/spec/spec-compat.md
// - Compat Specification: https://github.com/solo-io/wasm/blob/master/spec/spec-compat.md
URL string `json:"url"`

// PullSecretRef is a reference to the secret containing the credentials to pull the image.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,9 @@ spec:
description: |-
URL is the URL of the OCI image.
URL can be in the format of `registry/image:tag` or `registry/image@sha256:digest`.
The image format must follow the Wasm Artifact Image Specification or the Compat Spec.
The image format must follow the Wasm Artifact Image Specification or the Compat Specification.
- Wasm Artifact Image Specification: https://github.com/solo-io/wasm/blob/master/spec/spec.md
- Compat spec image: https://github.com/solo-io/wasm/blob/master/spec/spec-compat.md
- Compat Specification: https://github.com/solo-io/wasm/blob/master/spec/spec-compat.md
type: string
required:
- url
Expand Down
12 changes: 8 additions & 4 deletions internal/provider/kubernetes/predicates_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,14 @@ func TestValidateSecretForReconcile(t *testing.T) {
Name: "wasm-oci",
},
Spec: egv1a1.EnvoyExtensionPolicySpec{
TargetRef: gwapiv1a2.LocalPolicyTargetReferenceWithSectionName{
LocalPolicyTargetReference: gwapiv1a2.LocalPolicyTargetReference{
Kind: "Gateway",
Name: "scheduled-status-test",
PolicyTargetReferences: egv1a1.PolicyTargetReferences{
TargetRefs: []gwapiv1a2.LocalPolicyTargetReferenceWithSectionName{
{
LocalPolicyTargetReference: gwapiv1a2.LocalPolicyTargetReference{
Kind: "Gateway",
Name: "scheduled-status-test",
},
},
},
},
Wasm: []egv1a1.Wasm{
Expand Down
2 changes: 1 addition & 1 deletion site/content/en/latest/api/extension_types.md
Original file line number Diff line number Diff line change
Expand Up @@ -2002,7 +2002,7 @@ _Appears in:_

| Field | Type | Required | Description |
| --- | --- | --- | --- |
| `url` | _string_ | true | URL is the URL of the OCI image.<br />URL can be in the format of `registry/image:tag` or `registry/image@sha256:digest`.<br />The image format must follow the Wasm Artifact Image Specification or the Compat Spec.<br />- Wasm Artifact Image Specification: https://github.com/solo-io/wasm/blob/master/spec/spec.md<br />- Compat spec image: https://github.com/solo-io/wasm/blob/master/spec/spec-compat.md |
| `url` | _string_ | true | URL is the URL of the OCI image.<br />URL can be in the format of `registry/image:tag` or `registry/image@sha256:digest`.<br />The image format must follow the Wasm Artifact Image Specification or the Compat Specification.<br />- Wasm Artifact Image Specification: https://github.com/solo-io/wasm/blob/master/spec/spec.md<br />- Compat Specification: https://github.com/solo-io/wasm/blob/master/spec/spec-compat.md |
| `pullSecretRef` | _[SecretObjectReference](https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1.SecretObjectReference)_ | false | PullSecretRef is a reference to the secret containing the credentials to pull the image.<br />Only support Kubernetes Secret resource from the same namespace. |


Expand Down
2 changes: 1 addition & 1 deletion site/content/zh/latest/api/extension_types.md
Original file line number Diff line number Diff line change
Expand Up @@ -2002,7 +2002,7 @@ _Appears in:_

| Field | Type | Required | Description |
| --- | --- | --- | --- |
| `url` | _string_ | true | URL is the URL of the OCI image.<br />URL can be in the format of `registry/image:tag` or `registry/image@sha256:digest`.<br />The image format must follow the Wasm Artifact Image Specification or the Compat Spec.<br />- Wasm Artifact Image Specification: https://github.com/solo-io/wasm/blob/master/spec/spec.md<br />- Compat spec image: https://github.com/solo-io/wasm/blob/master/spec/spec-compat.md |
| `url` | _string_ | true | URL is the URL of the OCI image.<br />URL can be in the format of `registry/image:tag` or `registry/image@sha256:digest`.<br />The image format must follow the Wasm Artifact Image Specification or the Compat Specification.<br />- Wasm Artifact Image Specification: https://github.com/solo-io/wasm/blob/master/spec/spec.md<br />- Compat Specification: https://github.com/solo-io/wasm/blob/master/spec/spec-compat.md |
| `pullSecretRef` | _[SecretObjectReference](https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1.SecretObjectReference)_ | false | PullSecretRef is a reference to the secret containing the credentials to pull the image.<br />Only support Kubernetes Secret resource from the same namespace. |


Expand Down

0 comments on commit 7f8f8e0

Please sign in to comment.