feat(helm): support pulling envoyGateway image from a private registry (

#2335) * feat(helm): add imagePullSecrets support for envoyGateway image Signed-off-by: Shahar Harari <[email protected]> * run make generate Signed-off-by: Shahar Harari <[email protected]> * fix indentation Signed-off-by: Shahar Harari <[email protected]> --------- Signed-off-by: Shahar Harari <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Co-authored-by: zirain <[email protected]>
envoyproxy · Dec 27, 2023 · 787f48e · 787f48e
1 parent 690e469
commit 787f48e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/charts/gateway-helm/templates/certgen.yaml b/charts/gateway-helm/templates/certgen.yaml
@@ -33,6 +33,10 @@ spec:
           value: {{ .Values.kubernetesClusterDomain }}
         image: {{ .Values.deployment.envoyGateway.image.repository }}:{{ .Values.deployment.envoyGateway.image.tag | default .Chart.AppVersion }}
         imagePullPolicy: {{ .Values.deployment.envoyGateway.imagePullPolicy }}
+        {{- with .Values.deployment.envoyGateway.imagePullSecrets }}
+        imagePullSecrets:
+          {{- toYaml . | nindent 8 }}
+        {{- end }}
         name: envoy-gateway-certgen
       restartPolicy: Never
       securityContext:

diff --git a/charts/gateway-helm/templates/envoy-gateway-deployment.yaml b/charts/gateway-helm/templates/envoy-gateway-deployment.yaml
@@ -47,6 +47,10 @@ spec:
           value: {{ .Values.kubernetesClusterDomain }}
         image: {{ .Values.deployment.envoyGateway.image.repository }}:{{ .Values.deployment.envoyGateway.image.tag | default .Chart.AppVersion }}
         imagePullPolicy: {{ .Values.deployment.envoyGateway.imagePullPolicy }}
+        {{- with .Values.deployment.envoyGateway.imagePullSecrets }}
+        imagePullSecrets:
+          {{- toYaml . | nindent 8 }}
+        {{- end }}
         livenessProbe:
           httpGet:
             path: /healthz

diff --git a/charts/gateway-helm/values.tmpl.yaml b/charts/gateway-helm/values.tmpl.yaml
@@ -4,6 +4,7 @@ deployment:
       repository: ${ImageRepository}
       tag: '${ImageTag}'
     imagePullPolicy: Always
+    imagePullSecrets: []
     resources:
       limits:
         cpu: 500m

diff --git a/site/content/en/latest/install/api.md b/site/content/en/latest/install/api.md
@@ -35,6 +35,7 @@ The Helm chart for Envoy Gateway
 | deployment.envoyGateway.image.repository | string | `"${ImageRepository}"` |  |
 | deployment.envoyGateway.image.tag | string | `"${ImageTag}"` |  |
 | deployment.envoyGateway.imagePullPolicy | string | `"Always"` |  |
+| deployment.envoyGateway.imagePullSecrets | list | `[]` |  |
 | deployment.envoyGateway.resources.limits.cpu | string | `"500m"` |  |
 | deployment.envoyGateway.resources.limits.memory | string | `"1024Mi"` |  |
 | deployment.envoyGateway.resources.requests.cpu | string | `"100m"` |  |