treat ipv6 case

Signed-off-by: Guy Daich <[email protected]>
envoyproxy · Dec 18, 2024 · 60a7961 · 60a7961
1 parent 9c83c5e
commit 60a7961
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/test/e2e/tests/certificate_rotation.go b/test/e2e/tests/certificate_rotation.go
@@ -45,14 +45,20 @@ var CertificateRotationTest = suite.ConformanceTest{
 			EnvoyGatewayLBSVC := "envoy-gateway-ext-lb"
 			EnvoyCertificateSecret := "envoy"
 			EnvoyGatewayXDSPort := 18000
+			var envoyGatewayAddr string
 
 			ctx := context.Background()
 			envoyGatewaySvc := &corev1.Service{}
 			err := suite.Client.Get(ctx, types.NamespacedName{Namespace: envoyGatewayNS, Name: EnvoyGatewayLBSVC}, envoyGatewaySvc)
 			require.NoError(t, err)
 			require.Len(t, envoyGatewaySvc.Status.LoadBalancer.Ingress, 1)
 			require.NotEmpty(t, envoyGatewaySvc.Status.LoadBalancer.Ingress[0].IP)
-			envoyGatewayAddr := fmt.Sprintf("%s:%d", envoyGatewaySvc.Status.LoadBalancer.Ingress[0].IP, EnvoyGatewayXDSPort)
+
+			if IPFamily == "ipv6" {
+				envoyGatewayAddr = fmt.Sprintf("[%s]:%d", envoyGatewaySvc.Status.LoadBalancer.Ingress[0].IP, EnvoyGatewayXDSPort)
+			} else {
+				envoyGatewayAddr = fmt.Sprintf("%s:%d", envoyGatewaySvc.Status.LoadBalancer.Ingress[0].IP, EnvoyGatewayXDSPort)
+			}
 
 			// get the current envoy TLS credentials
 			certNN := types.NamespacedName{Namespace: envoyGatewayNS, Name: EnvoyCertificateSecret}