fix url rewrite

Signed-off-by: Arko Dasgupta <[email protected]>
envoyproxy · Oct 30, 2023 · 5680ab4 · 5680ab4
1 parent a761900
commit 5680ab4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/internal/xds/translator/route.go b/internal/xds/translator/route.go
@@ -277,9 +277,9 @@ func buildXdsURLRewriteAction(destName string, urlRewrite *ir.URLRewrite, pathMa
 				(*urlRewrite.Path.PrefixMatchReplace == "" || *urlRewrite.Path.PrefixMatchReplace == "/") {
 				routeAction.RegexRewrite = &matcherv3.RegexMatchAndSubstitute{
 					Pattern: &matcherv3.RegexMatcher{
-						Regex: "^" + *pathMatch.Prefix,
+						Regex: "^" + *pathMatch.Prefix + `\/*`,
 					},
-					Substitution: "",
+					Substitution: "/",
 				}
 			} else {
 				routeAction.PrefixRewrite = *urlRewrite.Path.PrefixMatchReplace

diff --git a/...al/xds/translator/testdata/out/xds-ir/http-route-rewrite-root-path-url-prefix.routes.yaml b/...al/xds/translator/testdata/out/xds-ir/http-route-rewrite-root-path-url-prefix.routes.yaml
@@ -16,4 +16,5 @@
         cluster: rewrite-route-dest
         regexRewrite:
           pattern:
-            regex: ^/origin/
+            regex: ^/origin/\/*
+          substitution: /