Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: add todo information and supplementary function comments
Browse files Browse the repository at this point in the history
ShyunnY committed Feb 25, 2024
1 parent 478a3f9 commit 3d15e33
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions internal/cmd/egctl/config_ratelimit.go
Original file line number Diff line number Diff line change
@@ -25,9 +25,9 @@ import (
)

var (
defaultRateLimitNamespace = "envoy-gateway-system"
defaultConfigMap = "envoy-gateway-config"
defaultConfigMapKey = "envoy-gateway.yaml"
defaultRateLimitNamespace = "envoy-gateway-system" // TODO: make this configurable until EG support
defaultConfigMap = "envoy-gateway-config" // TODO: make this configurable until EG support
defaultConfigMapKey = "envoy-gateway.yaml" // TODO: make this configurable until EG support
)

func ratelimitConfigCommand() *cobra.Command {
@@ -129,6 +129,8 @@ func fetchRunningRateLimitPods(cli kubernetes.CLIClient, namespace string, label
return rlNN, nil
}

// extractRateLimitConfig After turning on port forwarding through PortForwarder,
// construct a request and send it to the rate limit Pod to obtain relevant configuration information.
func extractRateLimitConfig(fw kubernetes.PortForwarder, rlPod types.NamespacedName) ([]byte, error) {

if err := fw.Start(); err != nil {

0 comments on commit 3d15e33

Please sign in to comment.