remove sectionName CEL validation until it is supported

Signed-off-by: Alice Wasko <[email protected]>
envoyproxy · Oct 27, 2023 · 2521dfc · 2521dfc
1 parent d927446
commit 2521dfc
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 37 deletions.
diff --git a/api/v1alpha1/backendtrafficpolicy_types.go b/api/v1alpha1/backendtrafficpolicy_types.go
@@ -40,7 +40,6 @@ type BackendTrafficPolicy struct {
 type BackendTrafficPolicySpec struct {
 	// +kubebuilder:validation:XValidation:rule="self.group == 'gateway.networking.k8s.io'", message="this policy can only have a targetRef.group of gateway.networking.k8s.io"
 	// +kubebuilder:validation:XValidation:rule="self.kind == 'Gateway' || self.kind == 'HTTPRoute' || self.kind == 'GRPCRoute' || self.kind == 'UDPRoute' || self.kind == 'TCPRoute' || self.kind == 'TLSRoute'", message="this policy can only have a targetRef.kind of Gateway/HTTPRoute/GRPCRoute/TCPRoute/UDPRoute/TLSRoute"
-	// +kubebuilder:validation:XValidation:rule="has(self.sectionName) ? self.kind == 'Gateway': true", message="sectionName can only be set when kind is 'Gateway'."
 	// +kubebuilder:validation:Required
 	//
 	// targetRef is the name of the resource this policy

diff --git a/charts/gateway-helm/crds/generated/gateway.envoyproxy.io_backendtrafficpolicies.yaml b/charts/gateway-helm/crds/generated/gateway.envoyproxy.io_backendtrafficpolicies.yaml
@@ -270,8 +270,6 @@ spec:
                   rule: self.kind == 'Gateway' || self.kind == 'HTTPRoute' || self.kind
                     == 'GRPCRoute' || self.kind == 'UDPRoute' || self.kind == 'TCPRoute'
                     || self.kind == 'TLSRoute'
-                - message: sectionName can only be set when kind is 'Gateway'.
-                  rule: 'has(self.sectionName) ? self.kind == ''Gateway'': true'
             required:
             - targetRef
             type: object

diff --git a/test/cel-validation/backendtrafficpolicy_test.go b/test/cel-validation/backendtrafficpolicy_test.go
@@ -133,40 +133,6 @@ func TestBackendTrafficPolicyTarget(t *testing.T) {
 				"spec.targetRef: Invalid value: \"object\": this policy can only have a targetRef.kind of Gateway/HTTPRoute/GRPCRoute/TCPRoute/UDPRoute/TLSRoute",
 			},
 		},
-		{
-			desc: "targetRef section name with gateway",
-			mutate: func(btp *egv1a1.BackendTrafficPolicy) {
-				btp.Spec = egv1a1.BackendTrafficPolicySpec{
-					TargetRef: gwapiv1a2.PolicyTargetReferenceWithSectionName{
-						PolicyTargetReference: gwapiv1a2.PolicyTargetReference{
-							Group: gwapiv1a2.Group("gateway.networking.k8s.io"),
-							Kind:  gwapiv1a2.Kind("Gateway"),
-							Name:  gwapiv1a2.ObjectName("eg"),
-						},
-						SectionName: &sectionName,
-					},
-				}
-			},
-			wantErrors: []string{},
-		},
-		{
-			desc: "targetRef section name with httproute",
-			mutate: func(btp *egv1a1.BackendTrafficPolicy) {
-				btp.Spec = egv1a1.BackendTrafficPolicySpec{
-					TargetRef: gwapiv1a2.PolicyTargetReferenceWithSectionName{
-						PolicyTargetReference: gwapiv1a2.PolicyTargetReference{
-							Group: gwapiv1a2.Group("gateway.networking.k8s.io"),
-							Kind:  gwapiv1a2.Kind("HTTPRoute"),
-							Name:  gwapiv1a2.ObjectName("eg"),
-						},
-						SectionName: &sectionName,
-					},
-				}
-			},
-			wantErrors: []string{
-				"spec.targetRef: Invalid value: \"object\": sectionName can only be set when kind is 'Gateway'.",
-			},
-		},
 	}
 
 	for _, tc := range cases {