Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix failing stats integration test on macOS #9607

Closed

Conversation

zuercher
Copy link
Member

@zuercher zuercher commented Jan 8, 2020

Since #9069, macOS builds have been failing because they use slightly
more memory for stats than the new limit. Bump limit to next even
multiple of 1000.

Risk Level: low, test change only
Docs Changes: n/a
Release Notes: n/a
Fixes: #9605

Signed-off-by: Stephan Zuercher [email protected]

Since envoyproxy#9069, macOS builds have been failing because they use slightly
more memory for stats than the new limit. Bump limit to next even
multiple of 1000.

Risk Level: low, test change only
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Stephan Zuercher <[email protected]>
@zuercher zuercher requested a review from jmarantz January 8, 2020 19:17
@mattklein123
Copy link
Member

This is fixed on master.

@zuercher zuercher deleted the zuercher_bump_stats_mem_limit branch January 8, 2020 22:07
@dio dio mentioned this pull request Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stats_integration_test is failing on Mac
2 participants