-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Upgrade Kafka dependencies to 2.3.1 #9582
Conversation
/wait |
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
92d1f45
to
cff62ac
Compare
…tation Signed-off-by: Adam Kotwasinski <[email protected]>
223da5d
to
c423a52
Compare
/assign @mattklein123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description:
Upgrade Kafka client & server dependencies to 2.3.1.
In detail, we generate C++ code from metadata files in Kafka Java client source:
AlterConfigs
&IncrementalAlterConfigs
have bothAlterConfig
sub-structures)This PR is the first one in upgrade series, I will need to follow up with upgrade to 2.4, it demands more work than I expected as it includes binary protocol changes described in https://cwiki.apache.org/confluence/display/KAFKA/KIP-482%3A+The+Kafka+Protocol+should+Support+Optional+Tagged+Fields
(tldr: new data types, changed structures, input json files also changed)
Risk Level: Low
Testing:
bazel test //test/extensions/filters/network/kafka/broker/integration_test:kafka_broker_integration_test --runs_per_test 100
Docs Changes: Kafka version mentions in docs
Release Notes: N/A