-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: include v1alpha1 in proto_sync.py #9175
Conversation
Signed-off-by: Derek Argueta <[email protected]>
@derekargueta I think we do need to have the tools do this, since these APIs might gain new fields before we do the v3 cut. I think it's fairly easy to do, check out |
I didn't want to add one-off logic but since we already handling vNalphaN for v2 in |
Signed-off-by: Derek Argueta <[email protected]>
Signed-off-by: Derek Argueta <[email protected]>
@derekargueta ah yeah. So, I think your tool changes make sense, but then we shouldn't have the actual protos in v3alpha. We're only upgrading packages that have either had a breaking change or transitively depend on a package that has been upgraded. We basically have a DAG of versions. |
Signed-off-by: Derek Argueta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description: Follow-up to #8133, these likely escaped detection since they're versioned "v1alpha1" and the cloning script only searches for the last major version. This should be a one-off to get these caught up so I'm not modifying the tooling to accommodate these.
Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Derek Argueta [email protected]