tls: shutdown all contexts when terminating server

[asraa]

When a server catches an Exception on initialization or is destructed, it calls terminate() to shutdown the listener manager, worker threads, and cluster manager among others. The ContextManager is also destroyed, but the destructor only removes contexts that are expired. This removes all contexts with a shutdown() method.

Fixes OSS-Fuzz Issue:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15760
Testing: Added crashing corpus

Signed-off-by: Asra Ali [email protected]

[lizan]

Where is terminate() called? That might from an exception thrown from a destructor, which is caused by another exception. If that's the case we need investigate why destructor throw exceptions.

[asraa]

Yes, terminate() here was called when server initialization caught an exception. I will investigate what was causing it for this testcase
It was caused by SDS not supported yet, because the testcases config uses session_ticket_keys_sds_secret_config

Perhaps I should only call the shutdown() method when there's an expected/known exception in the config?

[lizan]

@asraa no, calling shutdown() isn't bad itself, but since contexts_ are list of weak_ptr, clearing it in shutdown doesn't prevent any leak but just worked around the destructor ASSERT, the owned shared_ptr is live somewhere.

[asraa]

Oh gotcha. I traced down where that context was coming from. The sslContextManager() was holding a ClientContext that is created by the cluster. This was made in the call to createTransportSocketFactory when initializing a ClusterImplBase.

It seems like I should handle this in ClusterManager shutdown. Is that right?

[stale]

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[stale]

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!