Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: fix git SHA embedding #841

Closed
wants to merge 2 commits into from
Closed

bazel: fix git SHA embedding #841

wants to merge 2 commits into from

Commits on Apr 26, 2017

  1. bazel: fix git SHA embedding 

    Previously, the SHA generation genrule used a glob over .git/**
to figure out if anything changed. This does not work when envoy is
embedded in another git repo as a submodule, or is potentially built
from a tarball. This commit reworks the generation to expect an env
var called GIT_BUILD_SHA which will be used as the final SHA in the
build. CI has been updated to use the GIT SHA being built from.

If the env var is not defined, the SHA is set to a default SHA.

This commit also removes a dependency on version_lib from test main,
which was causing all tests to be relinked for no reason.
    @mattklein123
    mattklein123 committed Apr 26, 2017
    Configuration menu
    Copy the full SHA
    99d04b6 View commit details
    Browse the repository at this point in the history

  2. fix

    @mattklein123
    mattklein123 committed Apr 26, 2017
    Configuration menu
    Copy the full SHA
    5584104 View commit details
    Browse the repository at this point in the history