doc: fix formatting of regexes, disconnected comment #8285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some example regexes were rendered incorrectly on envoyproxy.io. I chose to try to find all the example regexes and make them literal text. This way the regexes are syntactically correct both in the raw proto and on the doc site. Also found an H2 protocol option with a missing paragraph due to a blank line vs. empty comment line. Risk: low, comment-only Testing: n/a Docs: updated Release Notes: n/a Signed-off-by: Stephan Zuercher <[email protected]>
|
/retest |
|
🔨 rebuilding |
junr03
approved these changes
Sep 19, 2019
|
ping @envoyproxy/api-shepherds (formatting-only comment changes) |
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Sep 24, 2019
Some example regexes were rendered incorrectly on envoyproxy.io. I chose to try to find all the example regexes and make them literal text. This way the regexes are syntactically correct both in the raw proto and on the doc site. Also found an H2 protocol option with a missing paragraph due to a blank line vs. empty comment line. Risk: low, comment-only Testing: n/a Docs: updated Release Notes: n/a Signed-off-by: Stephan Zuercher <[email protected]>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Some example regexes were rendered incorrectly on envoyproxy.io. I chose to try to find all the example regexes and make them literal text. This way the regexes are syntactically correct both in the raw proto and on the doc site. Also found an H2 protocol option with a missing paragraph due to a blank line vs. empty comment line. Risk: low, comment-only Testing: n/a Docs: updated Release Notes: n/a Signed-off-by: Stephan Zuercher <[email protected]>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Some example regexes were rendered incorrectly on envoyproxy.io. I chose to try to find all the example regexes and make them literal text. This way the regexes are syntactically correct both in the raw proto and on the doc site. Also found an H2 protocol option with a missing paragraph due to a blank line vs. empty comment line. Risk: low, comment-only Testing: n/a Docs: updated Release Notes: n/a Signed-off-by: Stephan Zuercher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some example regexes were rendered incorrectly on envoyproxy.io. I chose
to try to find all the example regexes and make them literal text. This
way the regexes are syntactically correct both in the raw proto and on
the doc site. Also found an H2 protocol option with a missing paragraph
due to a blank line vs. empty comment line.
Risk: low, comment-only
Testing: n/a
Docs: updated
Release Notes: n/a
Signed-off-by: Stephan Zuercher [email protected]