upstream: fix the header file path typo #8266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Zhuang <[email protected]>
|
/assign htuch |
PiotrSikora
reviewed
Sep 17, 2019
| @@ -11,7 +12,6 @@ | |||
| #include "common/stream_info/stream_info_impl.h" | |||
| #include "common/upstream/health_checker_base_impl.h" | |||
|
|
|||
| #include "include/envoy/api/_virtual_includes/api_interface/envoy/api/api.h" | |||
There was a problem hiding this comment.
It might be worth adding a check against _virtual_includes to ./tools/check_format.py.
There was a problem hiding this comment.
Yeah, can you pick this up as a follow-up?
There was a problem hiding this comment.
I added a regex check there. Wording could probably be better though.
alyssawilk
previously approved these changes
Sep 17, 2019
| @@ -11,7 +12,6 @@ | |||
| #include "common/stream_info/stream_info_impl.h" | |||
| #include "common/upstream/health_checker_base_impl.h" | |||
|
|
|||
| #include "include/envoy/api/_virtual_includes/api_interface/envoy/api/api.h" | |||
There was a problem hiding this comment.
Yeah, can you pick this up as a follow-up?
Signed-off-by: Xin Zhuang <[email protected]>
PiotrSikora
approved these changes
Sep 17, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Sep 24, 2019
Fix the header path error introudced in pr envoyproxy#8166 Risk Level: LOW Testing: N/A Signed-off-by: Xin Zhuang <[email protected]>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Fix the header path error introudced in pr envoyproxy#8166 Risk Level: LOW Testing: N/A Signed-off-by: Xin Zhuang <[email protected]>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Fix the header path error introudced in pr envoyproxy#8166 Risk Level: LOW Testing: N/A Signed-off-by: Xin Zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix the header path error introudced in pr #8166
Risk Level: LOW
Testing: N/A
Docs Changes: N/A
Release Notes: N/A