Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: Update protobuf and other needed dependencies #8196

Merged
merged 1 commit into from
Sep 17, 2019
Merged

bazel: Update protobuf and other needed dependencies #8196

merged 1 commit into from
Sep 17, 2019

Conversation

vadorovsky
Copy link
Contributor

@vadorovsky vadorovsky commented Sep 10, 2019

This change updated the following dependencies:

  • protobuf - 3.9.1
  • grpc - 1.22.1

And introduces the new dependencies, needed by the new protobuf:

  • rules_proto

Risk Level: Medium
Testing: Unit and integration tests.
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Michal Rostecki [email protected]

@vadorovsky vadorovsky changed the title [WIP] bazel: Update protobuf and other needed dependencies bazel: Update protobuf and other needed dependencies Sep 12, 2019
This change updated the following dependencies:

- protobuf - 3.9.1
- grpc - 1.22.1

And introduces the new dependencies, needed by the new protobuf:

- rules_proto

Risk Level: Medium
Testing: Unit and integration tests.
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Michal Rostecki <[email protected]>
@lizan lizan merged commit fbd9aa5 into envoyproxy:master Sep 17, 2019
@vadorovsky vadorovsky deleted the update-protobuf-3-9-1 branch September 18, 2019 11:25
@incfly
Copy link
Contributor

incfly commented Sep 19, 2019

FYI, I found with this change, my self installed bazel 0.28.0 is no longer being able to build the envoy, gives the error as

ERROR: Analysis of target '//source/exe:envoy-static' failed; build aborted: error loading package '@com_google_protobuf//': Unable to find package for @rules_java//java:defs.bzl: The repository '@rules_java' could not be resolved.

Changing the bazel to bazelisk as the ROOT/bazel/README.md suggests solve the problem. Not sure why though :)

@vadorovsky
Copy link
Contributor Author

It seems that bazel 0.28.x complains about rules_java, but 0.29.x doesn't.

@lizan
Copy link
Member

lizan commented Sep 20, 2019

Use Bazel version in .bazelversion file, which bazelisk automatically does.

danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Sep 24, 2019
This change updated the following dependencies:

- protobuf - 3.9.1
- grpc - 1.22.1

And introduces the new dependencies, needed by the new protobuf:

- rules_proto

Risk Level: Medium
Testing: Unit and integration tests.
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Michal Rostecki <[email protected]>
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
This change updated the following dependencies:

- protobuf - 3.9.1
- grpc - 1.22.1

And introduces the new dependencies, needed by the new protobuf:

- rules_proto

Risk Level: Medium
Testing: Unit and integration tests.
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Michal Rostecki <[email protected]>
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
This change updated the following dependencies:

- protobuf - 3.9.1
- grpc - 1.22.1

And introduces the new dependencies, needed by the new protobuf:

- rules_proto

Risk Level: Medium
Testing: Unit and integration tests.
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Michal Rostecki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants