fix portFromUrl when double protocol is provided #7838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revival of envoyproxy#7823 this fixes a particular exception case where an end-user configures a socket address to point at: `https://google.com` instead of just the hostname: `google.com`. instead of throwing an (stoi) error. because it can't turn: `//google.com` into a port. we now through a slightly more sane: `malformed url`. it isn't as good as a protoc-gen-validate message since it's not clear why: `tcp://` gets prepended, but I think it's digestable enough to know, you shouldn't be putting https there. not to mention it is a step forward from: `stoi`. Signed-off-by: Cynthia Coan <[email protected]>
jmarantz
approved these changes
Aug 7, 2019
|
@lizan for senior committer approval. |
|
/azp run envoy-macos |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lizan
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revival of #7823
Description:
this fixes a particular exception case where an end-user configures
a socket address to point at:
https://google.cominstead of justthe hostname:
google.com.instead of throwing an (stoi) error. because it can't turn:
//google.cominto a port. we now through a slightly more sane:malformed url. it isn't as good as a protoc-gen-validate messagesince it's not clear why:
tcp://gets prepended, but I think it'sdigestable enough to know, you shouldn't be putting https there.
not to mention it is a step forward from:
stoi.Risk Level: Low
Testing:
Not only are there unit tests, but you can run through the following configurations and
see the new error messages.
Docs Changes: None
Release Notes: None