-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cds: Add general-purpose LB policy configuration #7744
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a23fd06
cds: Add general-purpose LB policy configuration.
markdroth 405f55e
Fix field number conflict.
markdroth b4e1249
Update next-free-field comment.
markdroth 9c53fc2
Fix formatting.
markdroth e9efa81
Add locality-picking policy and update comments.
markdroth 7ed94eb
Don't explicitly separate locality and endpoint picking. Use nesting …
markdroth 820cc92
Code review changes.
markdroth 3eb2cbe
Trigger use of new mechanism via a new enum value in lb_policy.
markdroth c2ff7a2
Remove now-unnecessary duplication of CommonLbConfig.
markdroth 7a31c45
Change enum name and add not-implemented-yet comment.
markdroth 5d61da6
Merge remote-tracking branch 'upstream/master' into cds_lb_policy
markdroth 0adc2d4
Fix not-implemented documentation tag.
markdroth 1e2958e
Add note about hierarchical LB policies.
markdroth 593d145
Fix doc reference.
markdroth c233712
address review comments
markdroth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very tiny: in Envoy, we have 100 char line length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.