tools: add coverage reporting & enforcement to router check

[dschaller]

Description: add coverage reporting & enforcement for routes in router check tool
Risk Level: Low
Testing: Manually tested
Docs Changes: Included
Release Notes: Included
Fixes #7567
Signed-off-by: Derek Schaller [email protected]

[dio]

Looks good. This seems super useful. WDYT of following tiny nit:

[dschaller]

@dio thanks for the review! Updated based on your feedback

[mattklein123]

This is a really awesome feature. A potential TODO/follow-up would be to have an option to print all of the routes that aren't covered?

[dschaller]

@mattklein123 thanks! Definitely agree about the follow up. I wanted to get basic coverage reporting and enforcement but I’d like to expand this to produce reports and include more comprehensive coverage of the fields for each route entry

[mattklein123]

@mattklein123 thanks! Definitely agree about the follow up. I wanted to get basic coverage reporting and enforcement but I’d like to expand this to produce reports and include more comprehensive coverage of the fields for each route entry

Awesome!

[dschaller]

@dio @rgs1 @mattklein123 updated this based on feedback. Can I get another look over this? :)

[mattklein123]

Thanks looks good with some small nits. Also, can you add a test that fails/passes some coverage results? It should be pretty easy if based on the other tests. Thank you!

/wait

[jyotimahapatra]

#7567

[jyotimahapatra]

We possibly can add a small check in route_tests.sh

[mattklein123]

/wait

[mattklein123]

Awesome, tiny nit and then ready to ship.

/wait

[mattklein123]

Thanks!

[mattklein123]

@dio any additional comments?

comments addressed

[jyotimahapatra]

#730