http: tracking object scope on the encode path #7603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Alyssa Wilk <[email protected]>
|
I think this is good for review! |
| @@ -98,6 +99,8 @@ class RouterTestBase : public testing::Test { | |||
|
|
|||
| // Make the "system time" non-zero, because 0 is considered invalid by DateUtil. | |||
| test_time_.setMonotonicTime(std::chrono::milliseconds(50)); | |||
|
|
|||
| EXPECT_CALL(callbacks_.dispatcher_, setTrackedObject(_)).Times(AnyNumber()); | |||
There was a problem hiding this comment.
Is this needed due to a strict mock? If so can you comment? If not can we remove? Same below?
Signed-off-by: Alyssa Wilk <[email protected]>
|
/retest |
|
🤷♀️ nothing to rebuild. |
mattklein123
approved these changes
Jul 22, 2019
| @@ -91,6 +91,7 @@ class RouterUpstreamLogTest : public testing::Test { | |||
| router_proto)); | |||
| router_.reset(new TestFilter(*config_)); | |||
| router_->setDecoderFilterCallbacks(callbacks_); | |||
| EXPECT_CALL(callbacks_.dispatcher_, setTrackedObject(_)).Times(testing::AnyNumber()); | |||
There was a problem hiding this comment.
Sorry can you add a similar comment here about the strict mock? Fine to do in your next change if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking the active stream on the encode path, for crash logging.
Risk Level: Medium (touching the router)
Testing: new unit tests
Docs Changes: n/a
Release Notes: n/a
#7300