Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove outdated statements #6743

Closed
wants to merge 3 commits into from
Closed

[docs] Remove outdated statements #6743

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df5f20b
remove deprecated doc statement
derekargueta Apr 29, 2019
6b8726e
a few more cases
derekargueta Apr 29, 2019
d0eda53
a missed case
derekargueta Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions include/envoy/server/filter_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ class NamedListenerFilterConfigFactory {
/**
* @return ProtobufTypes::MessagePtr create empty config proto message for v2. The filter
* config, which arrives in an opaque message, will be parsed into this empty proto.
* Optional today, will be compulsory when v1 is deprecated.
*/
virtual ProtobufTypes::MessagePtr createEmptyConfigProto() PURE;

Expand Down Expand Up @@ -252,8 +251,7 @@ class NamedNetworkFilterConfigFactory : public ProtocolOptionsFactory {
FactoryContext& context) PURE;

/**
* v2 variant of createFilterFactory(..), where filter configs are specified as proto. This may be
* optionally implemented today, but will in the future become compulsory once v1 is deprecated.
* v2 variant of createFilterFactory(..), where filter configs are specified as proto.
*/
virtual Network::FilterFactoryCb createFilterFactoryFromProto(const Protobuf::Message& config,
FactoryContext& context) {
Expand All @@ -265,8 +263,7 @@ class NamedNetworkFilterConfigFactory : public ProtocolOptionsFactory {
/**
* @return ProtobufTypes::MessagePtr create empty config proto message for v2. The filter
* config, which arrives in an opaque google.protobuf.Struct message, will be converted to
* JSON and then parsed into this empty proto. Optional today, will be compulsory when v1
* is deprecated.
* JSON and then parsed into this empty proto.
*/
virtual ProtobufTypes::MessagePtr createEmptyConfigProto() { return nullptr; }

Expand Down Expand Up @@ -301,9 +298,7 @@ class NamedHttpFilterConfigFactory : public ProtocolOptionsFactory {
FactoryContext& context) PURE;

/**
* v2 API variant of createFilterFactory(..), where filter configs are specified as proto. This
* may be optionally implemented today, but will in the future become compulsory once v1 is
* deprecated.
* v2 API variant of createFilterFactory(..), where filter configs are specified as proto.
*/
virtual Http::FilterFactoryCb createFilterFactoryFromProto(const Protobuf::Message& config,
const std::string& stat_prefix,
Expand All @@ -317,8 +312,7 @@ class NamedHttpFilterConfigFactory : public ProtocolOptionsFactory {
/**
* @return ProtobufTypes::MessagePtr create empty config proto message for v2. The filter
* config, which arrives in an opaque google.protobuf.Struct message, will be converted to
* JSON and then parsed into this empty proto. Optional today, will be compulsory when v1
* is deprecated.
* JSON and then parsed into this empty proto.
*/
virtual ProtobufTypes::MessagePtr createEmptyConfigProto() { return nullptr; }

Expand Down