Add cluster extension #6118

HenryYYang · 2019-02-27T23:41:47Z

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: Add cluster factory to allow creating and registering custom cluster.
Risk Level: medium
Testing: Added unit tests and integration tests
Docs Changes:
Release Notes: Added.
#5780

…sters Signed-off-by: Henry Yang <[email protected]>

Signed-off-by: Henry Yang <[email protected]>

…nto add-cluster-extension Signed-off-by: Henry Yang <[email protected]>

Signed-off-by: Henry Yang <[email protected]>

…-extension Signed-off-by: Henry Yang <[email protected]>

Signed-off-by: Henry Yang <[email protected]>

mattklein123

Thanks very excited for this. @htuch can you do a quick API pass on this to see if this will meet Google needs? @envoyproxy/maintainers in case anyone else wants to take a look. @HenryYYang I will take a full pass once the function is deleted per offline discussion. Thank you!

/wait

.bazelrc

DEPRECATED.md

api/envoy/api/v2/cds.proto

htuch · 2019-03-04T03:21:12Z

@mattklein123 this seems general enough to be useful for anything we'd want to do in terms of customer clusters. OTOH, I think our main interest today is making LB more extensible, which is orthogonal to cluster extensibility. I.e. we'd like to push out the existing LB to extensions and add our own, without needing to change from EdsCluster.

mattklein123

Thanks this is great! Flushing some more comments.

/wait

api/envoy/api/v2/cds.proto

docs/root/intro/arch_overview/service_discovery.rst

include/envoy/upstream/cluster_factory.h

source/common/upstream/cluster_factory_impl.cc

source/common/upstream/cluster_factory_impl.h

test/common/upstream/cluster_manager_impl_test.cc

test/proto/cluster_factory_config.proto

Signed-off-by: Henry Yang <[email protected]>

HenryYYang · 2019-03-04T22:13:42Z

🔨

Signed-off-by: Henry Yang <[email protected]>

mattklein123

Thanks this is really excellent work. A few small changes and then I think we are ready to ship!

/wait

docs/root/intro/arch_overview/service_discovery.rst

docs/root/intro/version_history.rst

include/envoy/upstream/cluster_factory.h

source/common/upstream/cluster_factory_impl.h

source/extensions/clusters/well_known_names.h

test/common/upstream/cluster_factory_impl_test.cc

test/integration/clusters/BUILD

test/integration/clusters/custom_static_cluster.cc

test/integration/custom_cluster_integration_test.cc

Signed-off-by: Henry Yang <[email protected]>

… header file Signed-off-by: Henry Yang <[email protected]>

Signed-off-by: Henry Yang <[email protected]>

mattklein123

Fantastic work! Thank you @HenryYYang!

@HenryYYang when you do your next PR for the new extension cluster, can you also take a look at https://github.com/envoyproxy/envoy/blob/master/REPO_LAYOUT.md and update it? I think we might be missing a few extensions, not just the clusters. Thank you!

HenryYYang added 7 commits February 18, 2019 05:03

Add cluster factory interface and implementation for the existing clu…

6dcb8de

…sters Signed-off-by: Henry Yang <[email protected]>

Add configurable factory

1ac5471

Signed-off-by: Henry Yang <[email protected]>

Fix format issues

b4253c2

Signed-off-by: Henry Yang <[email protected]>

make cluster type oneof

3e056bb

Signed-off-by: Henry Yang <[email protected]>

Fix format error.

f5420ee

Signed-off-by: Henry Yang <[email protected]>

Add integration tests

d3a9004

Signed-off-by: Henry Yang <[email protected]>

Updated comments and docs.

759e505

Signed-off-by: Henry Yang <[email protected]>

mattklein123 self-assigned this Feb 27, 2019

mattklein123 added the waiting label Feb 27, 2019

Merge branch 'master' into add-cluster-extension

789316a

repokitteh-read-only bot removed the waiting label Feb 28, 2019

mattklein123 added the waiting label Feb 28, 2019

HenryYYang added 6 commits February 27, 2019 17:39

Merge remote-tracking branch 'origin' into add-cluster-extension

e7b1625

Signed-off-by: Henry Yang <[email protected]>

remove TestBase from new tests

ef1f54a

Signed-off-by: Henry Yang <[email protected]>

Merge branch 'add-cluster-extension' of github.com:HenryYYang/envoy i…

cb3e0eb

…nto add-cluster-extension Signed-off-by: Henry Yang <[email protected]>

fix formatting

35b2c86

Signed-off-by: Henry Yang <[email protected]>

fix formatting

b3c41e2

Signed-off-by: Henry Yang <[email protected]>

fix formatting

a5e19da

Signed-off-by: Henry Yang <[email protected]>

repokitteh-read-only bot removed the waiting label Feb 28, 2019

mattklein123 added the waiting label Feb 28, 2019

fix clang tidy

5311662

Signed-off-by: Henry Yang <[email protected]>

repokitteh-read-only bot removed the waiting label Feb 28, 2019

fix typo

6634824

Signed-off-by: Henry Yang <[email protected]>

alyssawilk added the waiting label Feb 28, 2019

fix clang-tidy

587b1d0

Signed-off-by: Henry Yang <[email protected]>

repokitteh-read-only bot removed the waiting label Feb 28, 2019

HenryYYang added 2 commits February 28, 2019 11:21

Merge branch 'master' of github.com:envoyproxy/envoy into add-cluster…

ff123bf

…-extension Signed-off-by: Henry Yang <[email protected]>

delete deprecated api

d16d0b9

Signed-off-by: Henry Yang <[email protected]>

mattklein123 requested changes Mar 1, 2019

View reviewed changes

.bazelrc Outdated Show resolved Hide resolved

DEPRECATED.md Outdated Show resolved Hide resolved

api/envoy/api/v2/cds.proto Outdated Show resolved Hide resolved

api/envoy/api/v2/cds.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Mar 1, 2019

repokitteh-read-only bot removed the waiting label Mar 2, 2019

mattklein123 requested changes Mar 4, 2019

View reviewed changes

repokitteh-read-only bot added the waiting label Mar 4, 2019

Fix PR feedbacks

0cf38a8

Signed-off-by: Henry Yang <[email protected]>

repokitteh-read-only bot removed the waiting label Mar 4, 2019

Merge branch 'master' into add-cluster-extension

506f51b

Signed-off-by: Henry Yang <[email protected]>

mattklein123 added the waiting label Mar 5, 2019

Remove TestBase

f75d362

Signed-off-by: Henry Yang <[email protected]>

repokitteh-read-only bot removed the waiting label Mar 5, 2019

mattklein123 requested changes Mar 5, 2019

View reviewed changes

repokitteh-read-only bot added the waiting label Mar 5, 2019

Fix PR feedbacks

d51e41a

Signed-off-by: Henry Yang <[email protected]>

repokitteh-read-only bot removed the waiting label Mar 5, 2019

HenryYYang added 2 commits March 5, 2019 14:33

Fix missing import

6ccc257

Signed-off-by: Henry Yang <[email protected]>

Fix duplicate registration

0cb3806

Signed-off-by: Henry Yang <[email protected]>

mattklein123 added the waiting label Mar 6, 2019

HenryYYang added 2 commits March 6, 2019 10:53

Split implementation and registration of custom static cluster out of…

1716d48

… header file Signed-off-by: Henry Yang <[email protected]>

fix format

735524d

Signed-off-by: Henry Yang <[email protected]>

repokitteh-read-only bot added waiting and removed waiting labels Mar 6, 2019

remove CUSTOM_CLUSTER_CONFIG

b06aca8

Signed-off-by: Henry Yang <[email protected]>

repokitteh-read-only bot removed the waiting label Mar 7, 2019

HenryYYang and others added 2 commits March 7, 2019 16:16

Kick CI

0a53ccb

Signed-off-by: Henry Yang <[email protected]>

Merge branch 'master' into add-cluster-extension

ccc50cb

mattklein123 mentioned this pull request Mar 8, 2019

filters: install network filters on upstream connections #173 #6173

Closed

mattklein123 approved these changes Mar 8, 2019

View reviewed changes

mattklein123 merged commit 95998b4 into envoyproxy:master Mar 8, 2019

dfawley mentioned this pull request Mar 13, 2019

Stable Envoy API versions #6271

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cluster extension #6118

Add cluster extension #6118

HenryYYang commented Feb 27, 2019 •

edited

Loading

mattklein123 left a comment

htuch commented Mar 4, 2019

mattklein123 left a comment

HenryYYang commented Mar 4, 2019

mattklein123 left a comment

mattklein123 left a comment

Add cluster extension #6118

Add cluster extension #6118

Conversation

HenryYYang commented Feb 27, 2019 • edited Loading

mattklein123 left a comment

Choose a reason for hiding this comment

htuch commented Mar 4, 2019

mattklein123 left a comment

Choose a reason for hiding this comment

HenryYYang commented Mar 4, 2019

mattklein123 left a comment

Choose a reason for hiding this comment

mattklein123 left a comment

Choose a reason for hiding this comment

HenryYYang commented Feb 27, 2019 •

edited

Loading