tls: enable TLS 1.3 on the server-side (non-FIPS builds). #5459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Sikora <[email protected]>
mattklein123
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Very cool. This should make @moderation happy! I will defer to @lizan @ggreenway for better TLS review.
lizan
approved these changes
Jan 3, 2019
|
I am happy but I've also been happily serving 1.3 from my Envoy's (non-FIPS) for ages. This looks to change in the defaults. |
|
@moderation yeah, it just change in the defaults. |
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…#5459) Signed-off-by: Piotr Sikora <[email protected]> Signed-off-by: Fred Douglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Sikora [email protected]