tls: split client/server defaults. #5392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes. Signed-off-by: Piotr Sikora <[email protected]>
|
cc @ggreenway @lizan |
PiotrSikora
force-pushed
the
tls_client_server_defaults
branch
from
3438c44
to
d81fc73
Compare
|
@PiotrSikora code LGTM, though why this is needed? Will there be divergence between client and server in future? |
|
Yes, see #5401. |
lizan
approved these changes
Dec 27, 2018
ggreenway
approved these changes
Jan 2, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
No functional changes. Signed-off-by: Piotr Sikora <[email protected]> Signed-off-by: Fred Douglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes.
Signed-off-by: Piotr Sikora [email protected]