Add code owners entry for datadog extension #5030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Gilmour <[email protected]>
|
Do you also need something in OWNERS.md ? Also, do you mind if I submit an example similar to the other ones (jaeger and zipkin)? |
mattklein123
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
Thanks. @cgilmour feel free to do a follow up to add an example, that would be great!
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Caleb Gilmour <[email protected]> Signed-off-by: Fred Douglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Requested here, adding an item to codeowners.
Risk Level:
Low
Testing:
N/A
Docs Changes:
N/A
Release Notes:
N/A