Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy: fixes some errors #37388

Merged
merged 2 commits into from
Dec 2, 2024
Merged

clang-tidy: fixes some errors #37388

merged 2 commits into from
Dec 2, 2024

Conversation

mathetake
Copy link
Member

part of #28566

@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37388 was opened by mathetake.

see: more, trace.

@mathetake
fix
bad7d15 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake mathetake marked this pull request as ready for review November 27, 2024 05:49
RyanTheOptimist
RyanTheOptimist approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@phlax phlax merged commit 4707f0d into envoyproxy:main Dec 2, 2024
25 checks passed
@mathetake mathetake deleted the routerclangtidy branch December 4, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanTheOptimist RyanTheOptimist RyanTheOptimist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathetake @RyanTheOptimist @phlax