Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext_authz: expose fields latency, bytesSent and bytesReceived for CEL and logging #37074

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Merge branch 'main' into ext_authz_fields

457232b
Select commit
Loading
Failed to load commit list.
Open

ext_authz: expose fields latency, bytesSent and bytesReceived for CEL and logging #37074

Merge branch 'main' into ext_authz_fields
457232b
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/TSAN skipped Nov 15, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/37074/main@457232b)

hypnoce @hypnoce 457232b #37074 merge main@4c09752

ext_authz: expose fields latency, bytesSent and bytesReceived for CEL and logging

Commit Message:
ext_authz: expose fields latency, bytesSent and bytesReceived for CEL and logging

Additional Description:
This PR adds field access support for ext_authz filter state object ExtAuthzLoggingInfo. It exposes simple fields

  • latency
  • bytesSent
  • bytesReceived

This enables usage of ext_authz filter state in access logs, and any filter/logger using CEL after #35698.

Risk Level: Low

Testing:
Added field access test with valid and invalid field names

Docs Changes: added in proto api and docs

Release Notes: added filter state field latency, bytesSent and bytesReceived access for CEL and logging.

Platform Specific Features: none

PS: I'm not a native english speaker please let me know if I need to change any docs.

Environment

Request variables

Key Value
ref c67afcb
sha 457232b
pr 37074
base-sha 4c09752
actor hypnoce @hypnoce
message ext_authz: expose fields latency, bytesSent and bytesReceived for CEL and logging...
started 1731662297.754269
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true