[contrib][postgres] Remove <> after constructor in the PG proxy code #37038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angle brackets are not required after constructor and,
maybe, aren't even correct, though I'm not 100% sure on
what the standard says on the matter.
It seems like clang is fine with this syntax, but when you
try to build Envoy with gcc it complains:
```
./contrib/postgres_proxy/filters/network/source/postgres_message.h: At global scope:
./contrib/postgres_proxy/filters/network/source/postgres_message.h:397:14: error: expected unqualified-id before ')' token
397 | Sequence<>() = default;
| ^
Target //contrib/exe:envoy-static failed to build
```
Given that it's at least unusual to have angle brackets after
constructor in a class template specialization let's remove
them and satisfy both gcc and clang.
Signed-off-by: Mikhail Krinkin <[email protected]>
cpakulski
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Yes, it makes sense. Similar to https://github.com/envoyproxy/envoy/blob/main/contrib/postgres_proxy/filters/network/source/postgres_message.h#L367.
Thanks for catching it and correcting.
phlax
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Angle brackets are not required after constructor and, maybe, aren't even correct, though I'm not 100% sure on what the standard says on the matter.
It seems like clang is fine with this syntax, but when you try to build Envoy with gcc it complains:
Given that it's at least unusual to have angle brackets after constructor in a class template specialization let's remove them and satisfy both gcc and clang.
Additional Description:
It's one of the issue that prevent contrib build with gcc. It's not the original issue reported in #31807, but that issue is what started the investigation.
Risk Level: Low
Testing: bazel build with --config=gcc and --config=docker-gcc options and in various compliation modes.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A