proto: moving a utility to the one call location #36990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
/coverage |
|
Coverage for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/36990/coverage/index.html The coverage results are (re-)rendered each time the CI |
alyssawilk
force-pushed
the
wireCast
branch
2 times, most recently
from
cb12005
to
f9917ac
Compare
Signed-off-by: Alyssa Wilk <[email protected]>
adisuissa
reviewed
Nov 14, 2024
| @@ -16,14 +16,13 @@ ExtensionConfigBase::ExtensionConfigBase( | |||
| : proto_config_(proto_config), config_factory_(std::move(config_factory)), tls_slot_(tls) { | |||
| tls_slot_.set([](Event::Dispatcher&) { return std::make_shared<TlsFilterConfig>(); }); | |||
|
|
|||
| switch (proto_config_.config_type_case()) { | |||
| switch (proto_config_.config_type_case()) | |||
There was a problem hiding this comment.
Seems like a mistake (the opening brackets should be kept, and the closing one in line 26 should match the opening one in line 20)
| } | ||
| return (buffer_->size() == max_buf_size_); | ||
| } | ||
| bool full() const { return (buffer_ && buffer_->size() == max_buf_size_); } |
There was a problem hiding this comment.
Suggested change
| bool full() const { return (buffer_ && buffer_->size() == max_buf_size_); } | |
| bool full() const { return buffer_ && (buffer_->size() == max_buf_size_); } |
I may be wrong and this doesn't match the style-guide (a bit more readable IMHO).
There was a problem hiding this comment.
BTW: is this change related to the PR, or just a fly-by change?
| if (!match.ParseFromString(proto_config.match_config().SerializeAsString())) { | ||
| // This should should generally succeed, but if there are malformed UTF-8 strings in a | ||
| // message, this can fail. | ||
| throw EnvoyException("Unable to deserialize during wireCast()"); |
There was a problem hiding this comment.
Technically it is not wireCast() anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176