http: allow trigger GOAWAY from l7 filters #36306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
|
/retest |
|
/assign @yanavlasov |
1 similar comment
|
/assign @yanavlasov |
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
|
/retest |
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
|
/retest |
|
/wait @botengyao this needs a main merge. |
Signed-off-by: Boteng Yao <[email protected]>
yanavlasov
reviewed
Nov 6, 2024
| /** | ||
| * Attempt to send GOAWAY and close the connection, and no filter chain will move forward. | ||
| */ | ||
| virtual void sendGoAwayAndClose() PURE; |
There was a problem hiding this comment.
Can encoder filter send goaway?
There was a problem hiding this comment.
good point and no, kinda want to add the support incrementally, but added the handler for the encoder chain as well.
Signed-off-by: Boteng Yao <[email protected]>
Signed-off-by: Boteng Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: allow decoding filter trigger the connection level GOAWAY.
Additional Description: This is usually useful for dropping traffic more aggressively, especially for some attacks.
Risk Level: low
Testing: integration test