[Geoip+ci] Fix flaky release check in ci #36118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kateryna Nezdolii <[email protected]>
|
cc @phlax |
KBaichoo
approved these changes
Sep 13, 2024
| @@ -116,6 +115,7 @@ class GeoipProviderTestBase { | |||
| Filesystem::Watcher::OnChangedCb cb) { | |||
| { | |||
| absl::WriterMutexLock lock(&mutex_); | |||
| on_changed_cbs_.reserve(1); | |||
There was a problem hiding this comment.
Is the flake that we should only be accessing on_change_cbs_ with the mutex?
There was a problem hiding this comment.
yes, the tests were failing nondeterministically in somewhat random code paths before this fix (in release ci check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Partially Fixes #35829
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]