Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2: fix token session subdomain #35845

Merged
merged 15 commits into from
Aug 31, 2024
Merged

OAuth2: fix token session subdomain #35845

merged 15 commits into from
Aug 31, 2024

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Aug 26, 2024 •
edited
Loading

Commit Message:

  • If specified, use the token domain to calculate the encoded HMAC to allow HMAC validation across multiple subdomains
  • If specified, add the token domain to the Cookie delete headers

Additional Description:
Risk Level: low
Testing: unit test
Docs Changes: no
Release Notes: no
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Adding missing parts while implementing #35490 in #35491

@zhaohuabing
fix cookie subdomain
dd41eed 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
fix
5275df1 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing marked this pull request as draft August 26, 2024 12:57
@zhaohuabing zhaohuabing changed the title Fix subdomain OAuth2: fix token session subdomain Aug 26, 2024
@zhaohuabing
fix test
24fd543 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
fix test
ebe2754 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
fix test
d4583c5 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
fix test
3466bd4 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
fix test
ddc3d4e 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
add test for hmac with domain
0232ad1 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
add test for hmac with domain
74c3bd6 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
add test for hmac with domain
f32f61f 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
fix test
e62fc19 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
fix test
9bcc560 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
fix test
8ca0d93 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing
fix test
3f41180 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing marked this pull request as ready for review August 27, 2024 07:06
@zhaohuabing
minor wording
9ee8f95 
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing mentioned this pull request Aug 27, 2024
Merged
mattklein123
mattklein123 reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require a new release note or is this a bug fix for a previous recent PR?

/wait-any

@zhaohuabing
Copy link
Member Author

Does this require a new release note or is this a bug fix for a previous recent PR?

/wait-any

Hi @mattklein123 This doesn't need a new release note. It's just a bug fix for PR #35490 .

@mattklein123 mattklein123 merged commit 45dc281 into envoyproxy:main Aug 31, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@mattklein123 mattklein123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaohuabing @mattklein123