opentelemetrytracer: Allow sampler to set variant type span attribute… #32681
Check was skipped
This check was not triggered in this CI run
Details
Request (pr/32681/main@d88466a)
d88466a 
#32681 merge main@3ffc64c
opentelemetrytracer: Allow sampler to set variant type span attribute…
Commit Message: Allow sampler to set variant type span attributes
Additional Description: The opentelemetry sampler interface allows a sampler to add span attributes. The current Envoy implementation has the limitation that only string attributes are allowed.
In #32333 a dependency to Otel C++ API was added. This enables us to use the same type for attributes as Otel C++ SDK does.
Risk Level:
Testing: Unit, Integration, Manual
Docs Changes: N/A
Release Notes: Allow sampler to set variant type span attributes
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
Environment
Request variables
| Key | Value |
|---|---|
| ref | a8f5408e0851846ed5fdfca1ae44f3fbe49237c2 |
| sha | d88466a |
| pr | 32681 |
| base-sha | 3ffc64c |
| actor | @samohte |
| message | opentelemetrytracer: Allow sampler to set variant type span attribute…... |
| started | 1709726007.035552 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64 |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64 |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 30 |
| patch | 0 |
| dev | true |