golang filter: change register configFactory to filterFactory #32183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
approved these changes
Feb 4, 2024
doujiang24
force-pushed
the
config-factory
branch
from
c56e533
to
60da5cd
Compare
Signed-off-by: doujiang24 <[email protected]>
doujiang24
force-pushed
the
config-factory
branch
from
60da5cd
to
d918f44
Compare
spacewander
approved these changes
Feb 5, 2024
contrib/golang/filters/http/source/go/pkg/http/filtermanager.go
Outdated
Show resolved
Hide resolved
contrib/golang/filters/http/source/go/pkg/http/filtermanager.go
Outdated
Show resolved
Hide resolved
contrib/golang/filters/http/source/go/pkg/http/filtermanager.go
Outdated
Show resolved
Hide resolved
Signed-off-by: doujiang24 <[email protected]>
doujiang24
force-pushed
the
config-factory
branch
from
541a13d
to
f0c241f
Compare
|
Thanks @spacewander , all comments addressed~ |
spacewander
approved these changes
Feb 5, 2024
alyssawilk
approved these changes
Feb 5, 2024
spacewander
pushed a commit
to mosn/envoy
that referenced
this pull request
Jun 27, 2024
…roxy#32183) We followed the C++ style to register configFactory, but it's not a proper choice for Golang filter. Here is the Reasons: Golang introduced the ConfigParser interface to Parse/validate a config, configFactory does not need to parse config. better performance. By using fiterFactory, we could ommit generate a closure per http request, that may take ~1ns. Yep, this is a breaking change, people need to change the register API. So, I suggest we fix it earlier. Signed-off-by: doujiang24 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We followed the C++ style to register configFactory, but it's not a proper choice for Golang filter.
Here is the Reasons:
Yep, this is a breaking change, people need to change the register API.
So, I suggest we fix it earlier.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]