Opentelemetry stream fix #31844
Merged
Opentelemetry stream fix #31844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Banerjee <[email protected]>
Signed-off-by: ashish b <[email protected]>
Signed-off-by: ashish b <[email protected]>
Signed-off-by: Ashish Banerjee <[email protected]>
…voy into opentelemetry-stream-fix Signed-off-by: Ashish Banerjee <[email protected]>
Signed-off-by: Ashish Banerjee <[email protected]>
Signed-off-by: ashish b <[email protected]>
Signed-off-by: Ashish Banerjee <[email protected]>
Since we no longer stream traces, this name is more accurate Signed-off-by: Ashish Banerjee <[email protected]>
…voy into opentelemetry-stream-fix Signed-off-by: Ashish Banerjee <[email protected]>
…m-fix Signed-off-by: Ashish Banerjee <[email protected]>
Signed-off-by: Ashish Banerjee <[email protected]>
Signed-off-by: Ashish Banerjee <[email protected]>
…m-fix Signed-off-by: Ashish Banerjee <[email protected]>
Signed-off-by: Ashish Banerjee <[email protected]>
|
Creating a new pull request here because I don't know how to reopen #29011 Adding this in the hopes that it addresses #31497 (comment) |
|
@htuch When you get a chance, would you mind taking a look? I was unable to figure out how to open the last pull request unfortunately, so I decided to just create this one instead. Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: use unary RPC calls for OpenTelemetry trace export
Additional Description: The OpenTelemetry exporter was previously using client-side streaming for exporting trace data. This appears to work fine with the reference OpenTelemetry collector, but some collectors (DataPrepper for one example) instead seem to expect unary RPC calls for trace exports (in accordance with the OpenTelemetry specification). It seems that Data Prepper appears to rely specifically on the end-stream flag arriving in order for it to properly process the trace exports.
Risk Level: medium
Testing: no new tests
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]