Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix h3_request to work with delays #31842

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

ravenblackx
Copy link
Contributor

Commit Message: fix h3_request to work with delays
Additional Description: It turns out the aiohttp functions named with the prefix send_ only sometimes send, and would be more accurately prefixed queue_, or more accurately still queue_or_send_. This fixes the tool to always send.
Risk Level: None, test-tool only.
Testing: Tested manually with the call that wasn't working right before, and it does now.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

@ravenblackx
Copy link
Contributor Author

/retest

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ravenblackx

@ravenblackx ravenblackx merged commit d7ef6c0 into envoyproxy:main Jan 16, 2024
53 checks passed
@ravenblackx ravenblackx deleted the http3 branch January 16, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants