Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: rename @com_github_cncf_udpa to @com_github_cncf_xds #30802

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

sergiitk
Copy link
Contributor

@sergiitk sergiitk commented Nov 9, 2023

The repo has been renamed from cncf/udpa to cncf/xds long time ago, this is just to reflect this in the bazel repo name.
Otherwise this is a noop.


Commit Message: bazel: rename @com_github_cncf_udpa to @com_github_cncf_xds
Additional Description:

The repo has been renamed from cncf/udpa to cncf/xds long time ago, this is just to reflect this in the bazel repo name.
Otherwise this is a noop.

Risk Level: Low
Testing: do_ci.sh
Docs Changes: N/A (except some md files got updated)
Release Notes: N/A
Platform Specific Features: N/A

The repo has been renamed from cncf/udpa to cncf/xds long time ago,
this is just to reflect this in the bazel repo name.

Otherwise this is a noop.

Signed-off-by: Sergii Tkachenko <[email protected]>
@repokitteh-read-only repokitteh-read-only bot added v2-freeze api deps Approval required for changes to Envoy's external dependencies labels Nov 9, 2023
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy[\w/]*/(v1alpha\d?|v1|v2alpha\d?|v2))|(api/envoy/type/(matcher/)?\w+.proto).
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #30802 was opened by sergiitk.

see: more, trace.

@sergiitk
Copy link
Contributor Author

sergiitk commented Nov 9, 2023

Addresses good point brought in #30159 (comment).

cc @moderation @phlax

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with the stub to maintain downstream compat

im wondering if there is a way to add a deprecated notice

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 9, 2023
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit f66bd34 into envoyproxy:main Nov 10, 2023
111 of 112 checks passed
@sergiitk sergiitk deleted the rename-cncf_udpa-to-cncf_xds branch November 10, 2023 18:05
@sergiitk
Copy link
Contributor Author

For future references, corresponding downstream compat fix in grpc core: grpc/grpc#35603. Thanks @eugeneo!

sayboras added a commit to sayboras/proxy that referenced this pull request Mar 24, 2024
sayboras added a commit to sayboras/proxy that referenced this pull request Mar 25, 2024
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 2, 2024
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 5, 2024
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 6, 2024
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 16, 2024
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 16, 2024
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 16, 2024
sayboras added a commit to sayboras/proxy that referenced this pull request Apr 17, 2024
github-merge-queue bot pushed a commit to cilium/proxy that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants