-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: rename @com_github_cncf_udpa
to @com_github_cncf_xds
#30802
Conversation
The repo has been renamed from cncf/udpa to cncf/xds long time ago, this is just to reflect this in the bazel repo name. Otherwise this is a noop. Signed-off-by: Sergii Tkachenko <[email protected]>
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Addresses good point brought in #30159 (comment). |
Signed-off-by: Sergii Tkachenko <[email protected]>
Signed-off-by: Sergii Tkachenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, with the stub to maintain downstream compat
im wondering if there is a way to add a deprecated notice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
For future references, corresponding downstream compat fix in grpc core: grpc/grpc#35603. Thanks @eugeneo! |
The repo has been renamed from cncf/udpa to cncf/xds long time ago, this is just to reflect this in the bazel repo name.
Otherwise this is a noop.
Commit Message: bazel: rename
@com_github_cncf_udpa
to@com_github_cncf_xds
Additional Description:
Risk Level: Low
Testing: do_ci.sh
Docs Changes: N/A (except some md files got updated)
Release Notes: N/A
Platform Specific Features: N/A