-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github/ci: Assorted cleanups #30540
Merged
Merged
github/ci: Assorted cleanups #30540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlax
commented
Oct 26, 2023
phlax
force-pushed
the
ci-cleanup
branch
2 times, most recently
from
October 26, 2023 20:47
10974a9
to
a8944d1
Compare
phlax
changed the title
[WIP] github/ci: Assorted cleanups
github/ci: Assorted cleanups
Oct 26, 2023
phlax
changed the title
github/ci: Assorted cleanups
[WIP] github/ci: Assorted cleanups
Oct 27, 2023
phlax
changed the title
[WIP] github/ci: Assorted cleanups
github/ci: Assorted cleanups
Oct 27, 2023
this breaks in the PR but should resolve once landed - i have tested pretty extensively |
phlax
changed the title
github/ci: Assorted cleanups
[WIP] github/ci: Assorted cleanups
Oct 27, 2023
rewipped to fix issue |
phlax
force-pushed
the
ci-cleanup
branch
2 times, most recently
from
October 27, 2023 11:51
a83fe63
to
328e725
Compare
phlax
changed the title
[WIP] github/ci: Assorted cleanups
github/ci: Assorted cleanups
Oct 27, 2023
wbpcode
previously approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Signed-off-by: Ryan Northey <[email protected]>
wbpcode
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]