Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/ci: Assorted cleanups #30540

Merged
merged 1 commit into from
Oct 27, 2023
Merged

github/ci: Assorted cleanups #30540

merged 1 commit into from
Oct 27, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 26, 2023

  • fix signoff on version history sync
  • assorted cleanups

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft October 26, 2023 20:27
@phlax phlax force-pushed the ci-cleanup branch 2 times, most recently from 10974a9 to a8944d1 Compare October 26, 2023 20:47
@phlax phlax changed the title [WIP] github/ci: Assorted cleanups github/ci: Assorted cleanups Oct 26, 2023
@phlax phlax marked this pull request as ready for review October 26, 2023 20:49
@phlax phlax changed the title github/ci: Assorted cleanups [WIP] github/ci: Assorted cleanups Oct 27, 2023
@phlax phlax marked this pull request as draft October 27, 2023 08:08
@phlax phlax changed the title [WIP] github/ci: Assorted cleanups github/ci: Assorted cleanups Oct 27, 2023
@phlax phlax marked this pull request as ready for review October 27, 2023 10:52
@phlax
Copy link
Member Author

phlax commented Oct 27, 2023

this breaks in the PR but should resolve once landed - i have tested pretty extensively

@phlax phlax changed the title github/ci: Assorted cleanups [WIP] github/ci: Assorted cleanups Oct 27, 2023
@phlax phlax marked this pull request as draft October 27, 2023 11:08
@phlax
Copy link
Member Author

phlax commented Oct 27, 2023

rewipped to fix issue

@phlax phlax force-pushed the ci-cleanup branch 2 times, most recently from a83fe63 to 328e725 Compare October 27, 2023 11:51
@phlax phlax changed the title [WIP] github/ci: Assorted cleanups github/ci: Assorted cleanups Oct 27, 2023
@phlax phlax marked this pull request as ready for review October 27, 2023 11:52
wbpcode
wbpcode previously approved these changes Oct 27, 2023
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Signed-off-by: Ryan Northey <[email protected]>
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@phlax phlax merged commit d6e7e59 into envoyproxy:main Oct 27, 2023
73 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants