Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify/packages: Force rebuild of docker image #29919

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 3, 2023

This ensures a rebuild of the Docker image before running package verify tests

When changing the version number it was creating a mismatch between what was being tested and what was expected

This flag is probably a good idea generally as it will still rebuild from cache but will expire anything that has changed

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax force-pushed the verify-distro-rebuild branch from 19ffa82 to 875fb01 Compare October 3, 2023 10:32
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo you commenting why this is helpful in the submit notes, since it's not obvoius to !phlax folks

@phlax phlax merged commit d52b4f4 into envoyproxy:main Oct 3, 2023
phlax added a commit to phlax/envoy that referenced this pull request Oct 3, 2023
phlax added a commit to phlax/envoy that referenced this pull request Oct 3, 2023
phlax added a commit that referenced this pull request Oct 3, 2023
phlax added a commit that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants