fake_upstream: subtract already read bytes from required frame length #29890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ohadvano <[email protected]>
zuercher
approved these changes
Oct 2, 2023
|
I got to this bug while trying to fix the flaky tests as described in: #29518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Description: when reading gRPC frame in
FakeStream, in case a gRPC frame is received in multiple data payloads, it's required to subtract the count of bytes already read on previous payloads from the expected bytes left to wait for. Otherwise -FakeStreamwill keep waiting for the original frame length, although thebody_has already been drained from the first data payload.