Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router: propagate shadow state to upstream info #29858

Merged
merged 3 commits into from
Oct 3, 2023
Merged

router: propagate shadow state to upstream info #29858

merged 3 commits into from
Oct 3, 2023

Conversation

paul-r-gall
Copy link
Contributor

Commit Message: router: propagate shadow state to upstream stream info
Risk Level: None
Testing: Unit tests
Docs Changes: None

@paul-r-gall
Copy link
Contributor Author

/assign @envoyproxy/first-pass-reviewers

@repokitteh-read-only
Copy link

@envoyproxy/first-pass-reviewers cannot be assigned to this issue.

🐱

Caused by: a #29858 (comment) was created by @paul-r-gall.

see: more, trace.

@paul-r-gall
Copy link
Contributor Author

/assign-from @envoyproxy/first-pass-reviewers

@repokitteh-read-only
Copy link

@envoyproxy/first-pass-reviewers assignee is @silverstar194

🐱

Caused by: a #29858 (comment) was created by @paul-r-gall.

see: more, trace.

@ravenblackx ravenblackx self-assigned this Sep 29, 2023
@paul-r-gall
remove NOLINT
5340c5b 
Signed-off-by: Paul Ogilby <[email protected]>
silverstar194
silverstar194 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@silverstar194 silverstar194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass looks good to me.

source/common/router/upstream_request.cc Outdated Show resolved Hide resolved
@paul-r-gall
rm whitespace
6bb2833 
Signed-off-by: Paul Ogilby <[email protected]>
@paul-r-gall
Copy link
Contributor Author

test failure looks like a flake.

@ravenblackx
Copy link
Contributor

@wbpcode for senior maintainer approval since this is touching core stuff.

@ravenblackx ravenblackx removed their assignment Oct 2, 2023
@wbpcode
Copy link
Member

wbpcode commented Oct 3, 2023

/retest

wbpcode
wbpcode approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@paul-r-gall
Copy link
Contributor Author

Thanks @wbpcode -- is there anything else you need from me before merging?

@wbpcode
Copy link
Member

wbpcode commented Oct 3, 2023

Actually nothing, let 's land it now.

@wbpcode wbpcode merged commit 184dacf into envoyproxy:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbpcode wbpcode wbpcode approved these changes

@silverstar194 silverstar194 silverstar194 approved these changes

@ravenblackx ravenblackx ravenblackx approved these changes

Assignees

@silverstar194 silverstar194

@wbpcode wbpcode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paul-r-gall @ravenblackx @wbpcode @silverstar194