Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: fix flaky gso test #29855

Merged
merged 2 commits into from
Oct 2, 2023
Merged

quic: fix flaky gso test #29855

merged 2 commits into from
Oct 2, 2023

Conversation

danzh2010
Copy link
Contributor

Commit Message: potential fix to flakiness caused by missing Read event when I/O event callback is triggered.

test/common/network/udp_listener_impl_test.cc:610: Failure
Actual function call count doesn't match EXPECT_CALL(listener_callbacks_, onReadReady())...
         Expected: to be called once
           Actual: never called - unsatisfied and active

This indicates Read event is not present when the test is unblocked. Maybe a Write only event is bubbled up at the beginning.

Risk Level: low, test only
Testing: existing tests pass
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Fixes #29310

Signed-off-by: Dan Zhang <[email protected]>
Signed-off-by: Dan Zhang <[email protected]>
@danzh2010
Copy link
Contributor Author

/retest

@ravenblackx ravenblackx self-assigned this Sep 29, 2023
@danzh2010
Copy link
Contributor Author

/retest

@zuercher zuercher merged commit 1eb64ee into envoyproxy:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IpVersions/UdpListenerImplTest.UdpGroBasic/IPv4 flaked
4 participants