ci: Use clang-tidy tools from toolshed #29848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
force-pushed
the
clang-tidy-toolshed
branch
3 times, most recently
from
a8e8409 to
39f4899
Compare
phlax
changed the title
|
cc @wbpcode |
phlax
force-pushed
the
clang-tidy-toolshed
branch
3 times, most recently
from
6141f16 to
45b11ba
Compare
Signed-off-by: Ryan Northey <[email protected]>
phlax
force-pushed
the
clang-tidy-toolshed
branch
from
45b11ba to
3fd8652
Compare
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
ravenblackx
approved these changes
Sep 28, 2023
phlax
pushed a commit
that referenced
this pull request
Nov 22, 2024
`run_clang_tidy.sh` has been removed from the CI in #29848 and not used anymore. Furthermore, it's broken on the main branch, so it's better to remove the file completely to avoid confusing new contributors. Signed-off-by: Takeshi Yoneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up the clang_tidy ci target using the recently added/experimental aspect from toolshed
The upstream needs some work before we can fully enable this for CI - but this at least allows it to be run locally, and makes it easier to run ci testing in the interim
For some reason, using the bazel clang-tidy binary we have setup in the repo fails flakily so i also need to investigate that further. For now it uses the host clang-tidy
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]