server: un-revert #2568 with a fix to initialize logging before validation #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method (envoyproxy#2568)" (envoyproxy#2613)" This reverts commit 034135f. Signed-off-by: Joshua Marantz <[email protected]>
Signed-off-by: Joshua Marantz <[email protected]>
This was referenced Feb 15, 2018
|
CI still running, but: |
htuch
approved these changes
Feb 15, 2018
dnoe
approved these changes
Feb 15, 2018
lita
pushed a commit
to lita/envoy
that referenced
this pull request
Feb 15, 2018
…gging before validation (envoyproxy#2623)" This reverts commit 89b1ea6.
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* push generated wasm file in post submit * rename sha256 file * add check before push wasm file * clean up
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: JP Simard <[email protected]>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reverts #2613 the revert of #2568
Fixed the underlying issue which was that logging was not initialized during validation, so it ran lockless. This caused intermittent tsan errors. Although #2619 makes the failure immediate and consistent by asserting that logging has been initialized prior to spawning any threads.
Risk Level: Medium -- the earlier #2568 caused intermittent tsan errors which we believe to be fixed, but #2568 was medium-risk in the first place.
Release Notes: N/A