tools, github: Add current SOURCE_VERSION writer #23577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a script to produce SOURCE_VERSION which is useful to build envoy in a non-git (from an extracted release tarball) directory. Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
dio
changed the title
Signed-off-by: Dhi Aurrahman <[email protected]>
Signed-off-by: Dhi Aurrahman <[email protected]>
|
/assign @phlax |
phlax
reviewed
Oct 20, 2022
There was a problem hiding this comment.
looks good @dio
im wondering if we should wrap the code in a main function and use a if __name__ == "__main__": block to trigger it - it just means it wont run just from being imported
im also wondering if we need to add some info somewhere to say to run this before running any bazel tasks (for a tarball build)
phlax
reviewed
Oct 20, 2022
Signed-off-by: Dhi Aurrahman <[email protected]>
|
Thanks for the review @phlax. I added some lines in |
Signed-off-by: Dhi Aurrahman <[email protected]>
phlax
reviewed
Oct 20, 2022
Signed-off-by: Dhi Aurrahman <[email protected]>
phlax
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: This adds a script to produce the
SOURCE_VERSIONfile which is useful to build envoy in a non-git (from an extracted release tarball) directory. See:bazel/get_workspace_statusfor more information.Relevant: #2181.
Additional Description: This is useful to have a way to produce
SOURCE_VERSION, for example, to solve: https://github.com/Homebrew/homebrew-core/blob/923bb7a622b86876a662d1ed4a7ac51ccb2befcf/Formula/envoy.rb#L4. So downstream builder can consume release tarballs to build envoy without adding custom scripts to createSOURCE_VERSION.Risk Level: Low, since this is an optional tool.
Testing: Run the script in git and non-git environments.
Docs Changes: Added.
Release Notes: N/A
Platform-Specific Features: N/A