Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listener Fuzzer: avoid dangling reference to dtor unique_ptr #23537

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

KBaichoo
Copy link
Contributor

Let fuzzer own filter to avoid dangling reference if listener filter chain doesn't get created in connect.

We'd need to upgrade googletest in order to support moveable actions hence why I can't just move the filter into the lambda, but we have some build breakages associated with googletest, a windows patch.

Signed-off-by: Kevin Baichoo [email protected]

Commit Message: Listener Fuzzer: avoid dangling reference to dtor unique_ptr.
Additional Description:
Risk Level: low (fuzz)
Testing: ran fuzzer
Docs Changes: na
Release Notes: na
Platform Specific Features:
Fixes #23520

chain doesn't get created in connect.

Signed-off-by: Kevin Baichoo <[email protected]>
@wrowe wrowe requested a review from soulxu October 18, 2022 17:33
@wrowe
Copy link
Contributor

wrowe commented Oct 18, 2022

@soulxu If you want to give this a nod, I'll try to sweep it in to the release

@soulxu
Copy link
Member

soulxu commented Oct 19, 2022

Thanks! This LGTM

Copy link
Contributor

@wrowe wrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@wrowe wrowe merged commit 2f6f60d into envoyproxy:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null-pointer-dereference - Envoy::Server::ActiveTcpSocket::GenericListenerFilter::onAccept
3 participants