Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the coverage report for Wasm #23055

Merged
merged 16 commits into from
Dec 6, 2022
Merged

Improve the coverage report for Wasm #23055

merged 16 commits into from
Dec 6, 2022

Conversation

ingwonsong
Copy link
Contributor

@ingwonsong ingwonsong commented Sep 9, 2022 •
edited
Loading

Signed-off-by: Ingwon Song [email protected]

Fixes #11986

@ingwonsong ingwonsong requested a review from lizan as a code owner September 9, 2022 22:15
@ingwonsong ingwonsong force-pushed the cov-2 branch 3 times, most recently from 27104c7 to e1a9525 Compare September 11, 2022 14:47
@htuch
Copy link
Member

htuch commented Sep 12, 2022

/assign-from @envoyproxy/first-pass-reviewers

@repokitteh-read-only
Copy link

@envoyproxy/first-pass-reviewers assignee is @daixiang0

🐱

Caused by: a #23055 (comment) was created by @htuch.

see: more, trace.

@ingwonsong ingwonsong marked this pull request as draft September 12, 2022 17:05
@ingwonsong ingwonsong marked this pull request as ready for review September 12, 2022 18:57
@ingwonsong
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23055 (comment) was created by @ingwonsong.

see: more, trace.

@ingwonsong ingwonsong force-pushed the cov-2 branch 3 times, most recently from ca94a1a to 08bfe16 Compare September 12, 2022 22:27
@ingwonsong
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23055 (comment) was created by @ingwonsong.

see: more, trace.

@daixiang0
Copy link
Member

Please make CI happy then remove WIP prefix, thanks.

@ingwonsong ingwonsong force-pushed the cov-2 branch 3 times, most recently from 8f69425 to 0650d27 Compare September 18, 2022 20:56
adisuissa
adisuissa previously approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

/assign @lizan

@ingwonsong
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23055 (comment) was created by @ingwonsong.

see: more, trace.

@ingwonsong ingwonsong force-pushed the cov-2 branch 4 times, most recently from 0a74a6a to ae8d0b8 Compare September 19, 2022 21:28
@ingwonsong
Remove memory include
d36271e 
Signed-off-by: Ingwon Song <[email protected]>
@ingwonsong
Rename the member variables
ab8fb0f 
Signed-off-by: Ingwon Song <[email protected]>
@ingwonsong
Add foreign_test
7edc843 
Signed-off-by: Ingwon Song <[email protected]>
@ingwonsong
Fix lint errors
b77fc11 
Signed-off-by: Ingwon Song <[email protected]>
@ingwonsong
Skip ForeignFunction tests when CEL parser is disabled
ae3afb4 
Signed-off-by: Ingwon Song <[email protected]>
@ingwonsong
reflect comments
e2a05ed 
Signed-off-by: Ingwon Song <[email protected]>
@ingwonsong
Reflect the comments.
b395a0f 
Signed-off-by: Ingwon Song <[email protected]>
@ingwonsong
reflect comments
efad369 
Signed-off-by: Ingwon Song <[email protected]>
@ingwonsong
Introduce ClearWasmRuntimeFactories to use RAII rather than TearDown …
3067e3e 
…of gtest

Signed-off-by: Ingwon Song <[email protected]>
@ingwonsong
Copy link
Contributor Author

ingwonsong commented Nov 29, 2022 •
edited
Loading

Resolve the conflict.

@phlax I reverted the changes in this PR for per_file_coverage.sh. We may need to address again after resolving of the issue #24164

@ingwonsong ingwonsong requested review from lizan and mpwarres and removed request for lizan and mpwarres November 29, 2022 21:52
@ingwonsong
Copy link
Contributor Author

@lizan Warm reminder.

@ingwonsong ingwonsong requested a review from adisuissa December 5, 2022 21:47
@ingwonsong
Copy link
Contributor Author

@adisuissa Can you take a look at this?

adisuissa
adisuissa approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa
Copy link
Contributor

Merging, as @lizan approved the PR.

@adisuissa adisuissa merged commit 022dabd into envoyproxy:main Dec 6, 2022
@ingwonsong ingwonsong deleted the cov-2 branch December 6, 2022 01:58
jpsim added a commit that referenced this pull request Dec 6, 2022
@jpsim
Merge remote-tracking branch 'origin/main' into mobile-update-bazelw-…
5c71677 
…to-pull-bazelisk-1.15.0

* origin/main:
  coverage: fixing a TODO (#24357)
  ci: Fix change detection (part 3) (#24347)
  wasm: Improve the coverage report for Wasm (#23055)
  coverage: adding tests, bumping up (#24351)

Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyessenov kyessenov kyessenov left review comments

@adisuissa adisuissa adisuissa approved these changes

@lizan lizan lizan approved these changes

@mpwarres mpwarres mpwarres approved these changes

@daixiang0 daixiang0 daixiang0 left review comments

Assignees

@mpwarres mpwarres

@lizan lizan

@daixiang0 daixiang0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extensions/common/wasm coverage